Skip to content

Skip top flaky tests - #51510

Merged
lanej0 merged 2 commits into
trunkfrom
e2e/skip/skip-flaky-e2e-tests-until-fixed
Sep 18, 2024
Merged

lanej0 merged 2 commits into
trunkfrom
e2e/skip/skip-flaky-e2e-tests-until-fixed

Conversation

@lanej0

@lanej0 lanej0 commented Sep 18, 2024

Copy link
Copy Markdown
Contributor

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR skips the top flaky e2e tests until they can be fixed.

  • Merchant → Local Pickup Settings updating the title in WC Settings updates the local pickup text in the block and vice/versa updating the title in WC Settings updates the local pickup text in the block and vice/versa GitHub Issue
  • Product Collection registration My Custom Collection with Advanced Preview Should display properly in Product Catalog template Should display properly in Product Catalog template GitHub Issue
  • Product Collection registration Product picker should be shown when selected product is deleted Product picker should be shown when selected product is deleted GitHub Issue
  • Product Collection when no results are found does not render does not render GitHub Issue

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Ensure CI passes (Blocks e2e tests in particular)

Changelog entry

  • Automatically create a changelog entry from the details below.
  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Details

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Changelog Entry Comment

Comment

This PR skips 4 e2e tests and makes no other changes

@lanej0 lanej0 closed this Sep 18, 2024
@lanej0 lanej0 reopened this Sep 18, 2024
@github-actions github-actions Bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Sep 18, 2024
@lanej0
lanej0 requested a review from a team September 18, 2024 16:26
@github-actions

Copy link
Copy Markdown
Contributor

Hi , @woocommerce/solaris

Apart from reviewing the code changes, please make sure to review the testing instructions and verify that relevant tests (E2E, Unit, Integration, etc.) have been added or updated as needed.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@lanej0
lanej0 enabled auto-merge (squash) September 18, 2024 16:30

@Stojdza Stojdza left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lanej0
lanej0 merged commit 9d135ee into trunk Sep 18, 2024
@lanej0
lanej0 deleted the e2e/skip/skip-flaky-e2e-tests-until-fixed branch September 18, 2024 16:43
@github-actions github-actions Bot added this to the 9.4.0 milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants