This repository was archived by the owner on Oct 20, 2026. It is now read-only.
Repository navigation
Purple: Use spacers instead of padding in FAQ accordion panels - #383
Merged
Merged
Conversation
Closed accordion panels keep their own padding visible: core's closed state and the theme's first-paint collapse rule both hide content only, and the padding is an inline style no stylesheet rule can cleanly beat (upstream: WordPress/gutenberg#80776). The FAQ answers' bottom padding therefore rendered as a gap under every closed question on the front end, while the editor, which hides panels outright, showed none. Convert the five panels to the convention the filter sidebars already use: blockGap 0 with a trailing spacing-30 spacer. Spacers are content, so the collapsed state clips them, and the open spacing is unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
gigitux
pushed a commit
to woocommerce/woocommerce
that referenced
this pull request
Oct 15, 2026
…/faq-panel-spacers Purple: Use spacers instead of padding in FAQ accordion panels
gigitux
pushed a commit
to woocommerce/woocommerce
that referenced
this pull request
Oct 15, 2026
…oo-themes#383) Closed accordion panels keep their own padding visible: core's closed state and the theme's first-paint collapse rule both hide content only, and the padding is an inline style no stylesheet rule can cleanly beat (upstream: WordPress/gutenberg#80776). The FAQ answers' bottom padding therefore rendered as a gap under every closed question on the front end, while the editor, which hides panels outright, showed none. Convert the five panels to the convention the filter sidebars already use: blockGap 0 with a trailing spacing-30 spacer. Spacers are content, so the collapsed state clips them, and the open spacing is unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
gigitux
pushed a commit
to woocommerce/woocommerce
that referenced
this pull request
Oct 15, 2026
…/faq-panel-spacers Purple: Use spacers instead of padding in FAQ accordion panels
gigitux
pushed a commit
to woocommerce/woocommerce
that referenced
this pull request
Oct 15, 2026
…oo-themes#383) Closed accordion panels keep their own padding visible: core's closed state and the theme's first-paint collapse rule both hide content only, and the padding is an inline style no stylesheet rule can cleanly beat (upstream: WordPress/gutenberg#80776). The FAQ answers' bottom padding therefore rendered as a gap under every closed question on the front end, while the editor, which hides panels outright, showed none. Convert the five panels to the convention the filter sidebars already use: blockGap 0 with a trailing spacing-30 spacer. Spacers are content, so the collapsed state clips them, and the open spacing is unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
gigitux
pushed a commit
to woocommerce/woocommerce
that referenced
this pull request
Oct 15, 2026
…/faq-panel-spacers Purple: Use spacers instead of padding in FAQ accordion panels
gigitux
pushed a commit
to woocommerce/woocommerce
that referenced
this pull request
Oct 16, 2026
…oo-themes#383) Closed accordion panels keep their own padding visible: core's closed state and the theme's first-paint collapse rule both hide content only, and the padding is an inline style no stylesheet rule can cleanly beat (upstream: WordPress/gutenberg#80776). The FAQ answers' bottom padding therefore rendered as a gap under every closed question on the front end, while the editor, which hides panels outright, showed none. Convert the five panels to the convention the filter sidebars already use: blockGap 0 with a trailing spacing-30 spacer. Spacers are content, so the collapsed state clips them, and the open spacing is unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
gigitux
pushed a commit
to gigitux/woocommerce
that referenced
this pull request
Oct 16, 2026
…oo-themes#383) Closed accordion panels keep their own padding visible: core's closed state and the theme's first-paint collapse rule both hide content only, and the padding is an inline style no stylesheet rule can cleanly beat (upstream: WordPress/gutenberg#80776). The FAQ answers' bottom padding therefore rendered as a gap under every closed question on the front end, while the editor, which hides panels outright, showed none. Convert the five panels to the convention the filter sidebars already use: blockGap 0 with a trailing spacing-30 spacer. Spacers are content, so the collapsed state clips them, and the open spacing is unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the front end every closed FAQ question showed a gap between the heading and its bottom border; the editor showed none. Closed accordion panels keep their own padding visible: both core's closed state and the theme's first-paint collapse rule (
height: 0+overflow clip) hide content only, and the panel padding is a serialized inline style that no stylesheet rule can cleanly override. This is core behavior, already tracked upstream as WordPress/gutenberg#80776 (reproduced on vanilla Gutenberg), so no new upstream issue was filed.Changes
patterns/about-faq-question-list.php: the five answer panels drop theirpadding-bottom: spacing-30in favor ofblockGap: 0plus a trailingspacing-30spacer, the same convention the product filter panels already use. Spacers are content, so the collapsed state clips them; each panel holds a single paragraph, so the open-state spacing is byte-identical to before.Testing
hidden), and unchanged for no-JS visitors (all panels open, spacing intact).🤖 Generated with Claude Code