Skip to content

Reassign css to proper div to remove white space below footer #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guergana merged 2 commits into from
Jan 16, 2024
Merged

Reassign css to proper div to remove white space below footer #832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bbbada
Reassign css to proper div to remove white space below footer
guergana Jan 10, 2024
b31e174
Disable no-multiple-template-root rule in project
guergana Jan 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ module.exports = {
'vue/no-deprecated-slot-scope-attribute': 'off',
'vue/no-v-for-template-key-on-child': 'off',
'vue/no-deprecated-destroyed-lifecycle': 'off',
'vue/no-v-model-argument': 'off'
'vue/no-v-model-argument': 'off',
'vue/no-multiple-template-root': 'off' // TODO: remove this rule in T351644
},
};
124 changes: 61 additions & 63 deletions resources/js/Pages/Layout.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,67 +1,65 @@
<template>
<div class="website">
<main class="content-wrap" ref="contentWrap">
<header ref="header">
<InertiaLink class="logo-link" href="/">
<div class="mismatch-finder-logo" />
<h1 class="visually-hidden">{{ $i18n('mismatch-finder-title') }}</h1>
</InertiaLink>
<div class="userSection" ref="userSection">
<div v-detect-click-outside="onClickOutsideLanguageSelector" class="languageSelector">
<LanguageSelectorButton :aria-label="$i18n('toggle-language-selector-button')"
@click="onToggleLanguageSelector">
<cdx-icon :icon="cdxIconLanguage" />
{{ currentLanguageAutonym }}
</LanguageSelectorButton>
<LanguageSelector v-show="showLanguageSelector" ref="languageSelector"
@close="onCloseLanguageSelector" @select="onChangeLanguage">
<template #no-results>
{{ $i18n('language-selector-no-results') }}
</template>
</LanguageSelector>
</div>
<auth-widget :user="user" />
<main class="content-wrap" ref="contentWrap">
<header ref="header">
<InertiaLink class="logo-link" href="/">
<div class="mismatch-finder-logo" />
<h1 class="visually-hidden">{{ $i18n('mismatch-finder-title') }}</h1>
</InertiaLink>
<div class="userSection" ref="userSection">
<div v-detect-click-outside="onClickOutsideLanguageSelector" class="languageSelector">
<LanguageSelectorButton :aria-label="$i18n('toggle-language-selector-button')"
@click="onToggleLanguageSelector">
<cdx-icon :icon="cdxIconLanguage" />
{{ currentLanguageAutonym }}
</LanguageSelectorButton>
<LanguageSelector v-show="showLanguageSelector" ref="languageSelector"
@close="onCloseLanguageSelector" @select="onChangeLanguage">
<template #no-results>
{{ $i18n('language-selector-no-results') }}
</template>
</LanguageSelector>
</div>
</header>
<slot />
</main>
<wikidata-tool-footer
content-class="content-wrap"
:labels="{
tool: $i18n('mismatch-finder-title'),
license: $i18n('mismatch-finder-license'),
}"
:urls="{
license: 'https://github.com/wmde/wikidata-mismatch-finder/blob/license/bsd-3-clause/LICENSE',
source: 'https://github.com/wmde/wikidata-mismatch-finder',
issues: 'https://phabricator.wikimedia.org/project/board/5385/'
}"
>
<section>
<h2 class="h5">{{ $i18n('mismatch-finder-footer-more-tools') }}</h2>
<p>
<a href="https://query.wikidata.org/querybuilder/">
{{ $i18n('tool-query-builder') }}
</a>
</p>
<p>
<a href="https://item-quality-evaluator.toolforge.org/">
{{ $i18n('tool-item-quality-evaluator') }}
</a>
</p>
<p>
<a href="https://wikidata-analytics.wmcloud.org/app/CuriousFacts">
{{ $i18n('tool-curious-facts') }}
</a>
</p>
<p>
<a href="https://github.com/wmde/wikidata-constraints-violation-checker">
{{ $i18n('tool-constraints-violation-checker') }}
</a>
</p>
</section>
</wikidata-tool-footer>
</div>
<auth-widget :user="user" />
</div>
</header>
<slot />
</main>
<wikidata-tool-footer
content-class="content-wrap"
:labels="{
tool: $i18n('mismatch-finder-title'),
license: $i18n('mismatch-finder-license'),
}"
:urls="{
license: 'https://github.com/wmde/wikidata-mismatch-finder/blob/license/bsd-3-clause/LICENSE',
source: 'https://github.com/wmde/wikidata-mismatch-finder',
issues: 'https://phabricator.wikimedia.org/project/board/5385/'
}"
>
<section>
<h2 class="h5">{{ $i18n('mismatch-finder-footer-more-tools') }}</h2>
<p>
<a href="https://query.wikidata.org/querybuilder/">
{{ $i18n('tool-query-builder') }}
</a>
</p>
<p>
<a href="https://item-quality-evaluator.toolforge.org/">
{{ $i18n('tool-item-quality-evaluator') }}
</a>
</p>
<p>
<a href="https://wikidata-analytics.wmcloud.org/app/CuriousFacts">
{{ $i18n('tool-curious-facts') }}
</a>
</p>
<p>
<a href="https://github.com/wmde/wikidata-constraints-violation-checker">
{{ $i18n('tool-constraints-violation-checker') }}
</a>
</p>
</section>
</wikidata-tool-footer>
</template>

<script setup lang="ts">
Expand Down Expand Up @@ -170,7 +168,7 @@ onBeforeUnmount(() => {
<style lang="scss">
@import '~@wmde/wikit-tokens/dist/_variables.scss';

.website {
#app {
box-sizing: border-box;
min-height: 100%;
display: flex;
Expand Down