Skip to content

Rewrite MismatchesTable with Vue3 syntax #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guergana merged 2 commits into from
Jan 9, 2024
Merged

Rewrite MismatchesTable with Vue3 syntax #828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9eb77b
Rewrite MismatchesTable with Vue3 syntax
guergana Jan 8, 2024
d25e0de
Adjust unit tests to new code
guergana Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 7 additions & 16 deletions resources/js/Components/MismatchesTable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,27 +22,18 @@
</wikit-table>
</template>

<script lang="ts">
import type { PropType } from 'vue';
import { defineComponent } from 'vue';
<script setup lang="ts">
import { Table as WikitTable } from '@wmde/wikit-vue-components';

import MismatchRow from './MismatchRow.vue';

import { LabelledMismatch } from '../types/Mismatch';
import type { LabelledMismatch } from '../types/Mismatch';

export default defineComponent({
components: {
MismatchRow,
WikitTable,
},
props: {
mismatches: Array as PropType<LabelledMismatch[]>,
disabled: {
type: Boolean,
default: false
}
}
withDefaults(defineProps<{
mismatches: LabelledMismatch[],
disabled: boolean
}>(), {
disabled: false
});
</script>

Expand Down
17 changes: 9 additions & 8 deletions tests/Vue/Components/MismatchesTable.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
import { mount } from '@vue/test-utils';
import MismatchesTable from '@/Components/MismatchesTable.vue';
import MismatchRow from '@/Components/MismatchRow.vue';
import { createI18n } from 'vue-banana-i18n';

const i18n = createI18n({
messages: {},
locale: 'en',
wikilinks: true
});

describe('MismatchesTable.vue', () => {
it('accepts a mismatches property', () => {
Expand All @@ -22,10 +29,7 @@ describe('MismatchesTable.vue', () => {
const wrapper = mount(MismatchesTable, {
props: { mismatches },
global: {
mocks: {
// Mock the banana-i18n plugin dependency
$i18n: key => key
}
plugins: [i18n]
}
});

Expand Down Expand Up @@ -59,10 +63,7 @@ describe('MismatchesTable.vue', () => {
const wrapper = mount(MismatchesTable, {
props: { disabled, mismatches },
global: {
mocks: {
// Mock the banana-i18n plugin dependency
$i18n: key => key
}
plugins: [i18n]
}
});

Expand Down