fix incorrect/redundant values

chukarave · chukarave · commit 7a013ad74d45 · 2024-01-16T12:43:41.000+01:00
diff --git a/resources/css/custom-variables.css b/resources/css/custom-variables.css
@@ -2,17 +2,17 @@
     /* spacing */
     --dimension-spacing-none: 0em;
     --dimension-spacing-xxsmall: 0.125em;
-    --dimension-spacing-xsmall: 0.250em;
-    --dimension-spacing-small: 0.500em;
-    --dimension-spacing-medium: 0.750em;
+    --dimension-spacing-xsmall: 0.25em;
+    --dimension-spacing-small: 0.5em;
+    --dimension-spacing-medium: 0.75em;
     --dimension-spacing-large: 1em;
-    --dimension-spacing-xlarge: 1.500em;
+    --dimension-spacing-xlarge: 1.5em;
     --dimension-spacing-xxlarge: 2em;
 
     /*layout */
-     --dimension-layout-xxsmall: 0.500rem;
+     --dimension-layout-xxsmall: 0.5rem;
      --dimension-layout-xsmall: 1rem;
-     --dimension-layout-small: 1.500rem;
+     --dimension-layout-small: 1.5rem;
      --dimension-layout-medium: 2rem;
-     --dimension-layout-large: 2.500rem;
+     --dimension-layout-large: 2.5rem;
 }
diff --git a/resources/js/Pages/Results.vue b/resources/js/Pages/Results.vue
@@ -384,7 +384,7 @@ h2 {
     gap: var(--dimension-layout-xsmall);
     // calculate the footer height to reserve space for
     // messages with two lines (1.5 line height plus padding)
-    min-height: calc(2*1.5em + 2*var(--dimension-spacing-large));
+    min-height: calc(2*var(--dimension-spacing-xlarge) + 2*var(--dimension-spacing-large));
 
     .form-success-message {
         max-width: 705px;
diff --git a/resources/sass/app.scss b/resources/sass/app.scss
@@ -46,7 +46,7 @@ h1, .h1 {
     margin: var(--dimension-layout-xsmall) 0;
 
     @media (min-width: $min-width-breakpoint-tablet) {
-        margin: var(--dimension-layout-small) 0;
+        margin: var(--dimension-layout-xsmall) 0;
     }
 }
 
diff --git a/resources/sass/noscript.scss b/resources/sass/noscript.scss
@@ -9,7 +9,7 @@ main {
     font-family: $font-family-system-sans;
     font-weight: $font-weight-normal;
     color: $color-base;
-    padding: 10vw var(----dimension-layout-small) var(----dimension-layout-small) var(----dimension-layout-small) var(----dimension-layout-small);
+    padding: 10vw var(----dimension-layout-small) var(----dimension-layout-small) var(----dimension-layout-small);
     max-width: 680px;
 
     @media (min-width: $min-width-breakpoint-tablet) {

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ h1, .h1 {`
`46`	`46`	`margin: var(--dimension-layout-xsmall) 0;`
`47`	`47`
`48`	`48`	`@media (min-width: $min-width-breakpoint-tablet) {`
`49`		`- margin: var(--dimension-layout-small) 0;`
	`49`	`+ margin: var(--dimension-layout-xsmall) 0;`
`50`	`50`	`}`
`51`	`51`	`}`
`52`	`52`