Skip to content

Conversation

@rti
Copy link
Contributor

@rti rti commented Aug 25, 2025

No description provided.

@rti rti requested a review from a team August 25, 2025 13:53
Copy link
Contributor

@lorenjohnson lorenjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I was expecting commits that were fix(wikibase): and fix(deploy):, respectively. Do you imagine not incrementing the wikibase image by a patch version? In general what is the release strategy here? Just one squash commit signally only the Deploy change?

@rti
Copy link
Contributor Author

rti commented Aug 25, 2025

Good question. Thanks for bringing this up.

The component notation in conventional commits (e.g. fix(component): bla) is not picked up by NX in order to assign changes to projects. The actual changes in git do. The component notation is used to distinguish between different parts within a project.

I think we should not squash the commits though, realizing just now as you question it. If we just merge this to main without squashing, and release everything unreleased, we will already have a version bump and changelog entry for wikibase triggered by this commit as well as a version bump and changelog entry for deploy triggered by this commit. I think this is ok. I will update the lint commit to follow conventional commits too though in order to not have unconventional commits on main.

I think after merging to main we should release wikibase and deploy, while the latter is the actual fix, the former is just to have the release on docker hub built by the latest build code.

@rti rti force-pushed the bump-wikibase-container-to-5 branch from 5d88d6f to 05785e4 Compare August 25, 2025 14:50
@rti
Copy link
Contributor Author

rti commented Aug 25, 2025

@lorenjohnson if you agree with that procedure, I would just go ahead, merge and release.

@lorenjohnson
Copy link
Contributor

lorenjohnson commented Aug 25, 2025

That is fine, and I get it. I would just prefer feat(): format in our conventional commit messages for consistency and clarity when perusing at the git log level. Don't care a bunch though, it is just what I had thought we had done fairly consistently to this point.

@rti rti force-pushed the bump-wikibase-container-to-5 branch from 05785e4 to c645772 Compare August 26, 2025 12:19
@rti rti force-pushed the bump-wikibase-container-to-5 branch from c645772 to 0ca6971 Compare August 26, 2025 12:19
@rti rti merged commit 79387b5 into main Aug 26, 2025
5 checks passed
@rti rti deleted the bump-wikibase-container-to-5 branch August 26, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants