-
Notifications
You must be signed in to change notification settings - Fork 43
docs(deploy): clarify running locally without dns #762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This adds some documentations about the issue where WDQS crashes when restarted with an empty database that never synced entities from MediaWiki. https://phabricator.wikimedia.org/T354266
…:wmde/wikibase-release-pipeline into T372177-improve-docs-for-running-locally
|
Sorry, I was out sick. Looking at this now -- |
|
I made the language a little bit clearer, but I have a thought on the technical side of things as an old DNS head. "example.com" is indeed publicly resolvable, just not to the thing people might want it to resolve to :) If we're going all the way out on a limb advising them to make /etc/hosts changes, we may want to suggest that they use either their own domain or a truly unresolvable domain like "yournamehere.wikibase". Just a thought -- |
|
So this is interesting. Even examples can be difficult 😄 I like your point. RFC2606 suggests to use e.g. |
This appears to be the more appropriate domain name to use as it explicitly targets DNS resolution related code. https://datatracker.ietf.org/doc/html/rfc2606#section-2
|
@datn done. Do you mind re-reviewing? |
datn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* docs(wdqs): details about the empty sync issue This adds some documentations about the issue where WDQS crashes when restarted with an empty database that never synced entities from MediaWiki. https://phabricator.wikimedia.org/T354266 * small edits to the new text * docs(deploy): clarify running locally without dns * T372177-improve-docs-for-running-locally clarified language just a tad * docs: switching example domain to .example tld This appears to be the more appropriate domain name to use as it explicitly targets DNS resolution related code. https://datatracker.ietf.org/doc/html/rfc2606#section-2 --------- Co-authored-by: Dan Shick <dan.shick@wikimedia.de>
https://phabricator.wikimedia.org/T372177