Skip to content

T370035 docs: add release checklist item: update dockerhub #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rti merged 1 commit into from
Jul 23, 2024
Merged

T370035 docs: add release checklist item: update dockerhub #730

rti merged 1 commit into from
Jul 23, 2024

Conversation

@rti
Copy link
Contributor

@rti rti commented Jul 17, 2024 •
edited
Loading

@lorenjohnson lorenjohnson self-requested a review July 17, 2024 19:25
lorenjohnson
lorenjohnson approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@lorenjohnson lorenjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! With upcoming CI/CD work this list is about to get revamped/a lot shorter, but this item I imagine will remain manual for some time.

Worth noting is that currently https://www.mediawiki.org/wiki/Wikibase/Docker links to the main branch and the deploy directory https://github.com/wmde/wikibase-release-pipeline/tree/main/deploy, but I was expecting it to link to the README.md at the tag of the most recent release, i.e. https://github.com/wmde/wikibase-release-pipeline/blob/v3.0.0/deploy/README.md

@rti
Copy link
Contributor Author

rti commented Jul 23, 2024

Worth noting is that currently https://www.mediawiki.org/wiki/Wikibase/Docker links to the main branch and the deploy directory https://github.com/wmde/wikibase-release-pipeline/tree/main/deploy, but I was expecting it to link to the README.md at the tag of the most recent release, i.e. https://github.com/wmde/wikibase-release-pipeline/blob/v3.0.0/deploy/README.md

Thanks for noting, put this in the ticket that handled that change https://phabricator.wikimedia.org/T343354

@rti rti merged commit 262f14f into main Jul 23, 2024
@rti rti deleted the T370035 branch July 23, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lorenjohnson lorenjohnson lorenjohnson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rti @lorenjohnson