Skip to content

Conversation

@rti
Copy link
Contributor

@rti rti commented Sep 21, 2023

@rti rti requested a review from a team September 21, 2023 14:37
@rti rti changed the title chore: manually trigger example test workflow T346210 test_example action is wasteful Sep 21, 2023
@rti rti mentioned this pull request Sep 21, 2023
Copy link
Member

@RickiJay-WMDE RickiJay-WMDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under what circumstances does the action now trigger? How do you manually trigger it?

@rti
Copy link
Contributor Author

rti commented Sep 25, 2023

Under what circumstances does the action now trigger? How do you manually trigger it?

It can only get triggered manually now. You can do it via the actions UI on the github website.

screenshot-20230925090056

@adeeri
Copy link
Contributor

adeeri commented Sep 25, 2023

Under what circumstances does the action now trigger? How do you manually trigger it?

It can only get triggered manually now. You can do it via the actions UI on the github website.

screenshot-20230925090056

If not on every run, when would you want to trigger it?

@rti
Copy link
Contributor Author

rti commented Sep 26, 2023

If not on every run, when would you want to trigger it?

This is a very good question. I think we still need a process for that. My guts says something like "directly before we publish a releaseF. I think this will naturally come up again when we discuss our distribution story. I added a note here: https://phabricator.wikimedia.org/T340234

@rti
Copy link
Contributor Author

rti commented Sep 26, 2023

@adeeri Do you agree merging it?

@rti rti requested a review from adeeri September 26, 2023 08:45
@adeeri
Copy link
Contributor

adeeri commented Sep 26, 2023

@adeeri Do you agree merging it?

Yes, thanks for adding the note so we don't lose it!

@rti rti merged commit b4b5f70 into main Sep 26, 2023
@rti rti deleted the T346210-test_example-action-is-wasteful branch September 26, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants