Skip to content

Commit cf5a4ef

Browse files
authored
Remove console log warning supression in test suite (#835)
Because of previous vue compatibility issues (T355239) we have been suppressing console log warnings during test suite execution. Now that we no longer have vue compat issues, we can remove the log suppression. Remove the log supression, and fix resulting warnings that have previously been invisible. Bug: T355168
1 parent 02c44e2 commit cf5a4ef

File tree

4 files changed

+3
-11
lines changed

4 files changed

+3
-11
lines changed

jest.config.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,6 @@ module.exports = {
99
'^@/(.*)$': '<rootDir>/src/$1',
1010
'\\.css$': '<rootDir>/tests/mocks/styleMock.js',
1111
},
12-
setupFiles: [
13-
'./jest.overrides.js',
14-
],
1512
testEnvironment: 'jsdom',
1613
testEnvironmentOptions: {
1714
customExportConditions: [ 'node', 'node-addons' ],

jest.overrides.js

Lines changed: 0 additions & 6 deletions
This file was deleted.

tests/unit/components/ItemLookup.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ function createLookup( propsOverrides: any = {} ): VueWrapper<any> {
1616
placeholder: 'some placeholder',
1717
searchForItems: jest.fn(),
1818
value: null,
19+
searchInput: 'input',
1920
...propsOverrides,
2021
},
2122
} );

tests/unit/main.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,13 @@ describe( 'createAndMount', () => {
99

1010
it( 'mounts created app on given selector', () => {
1111
const rootElement = document.createElement( 'div' );
12-
rootElement.id = 'test-app';
12+
rootElement.id = 'wbl-snl-intro-text-wrapper';
1313
document.body.append( rootElement );
1414
const discardedElement = document.createElement( 'div' );
1515
rootElement.append( discardedElement );
1616

1717
const instance = createAndMount( {
18-
rootSelector: '#test-app',
18+
rootSelector: '#wbl-snl-intro-text-wrapper',
1919
isAnonymous: false,
2020
licenseUrl: '',
2121
licenseName: '',

0 commit comments

Comments
 (0)