Skip to content

Commit ab37961

Browse files
author
Daniel Kinzler
committed
allow mysql comments
git-svn-id: https://svn.toolserver.org/svnroot/daniel/duesenstuff/trunk/gpClient@598 9f2c43bc-b3c0-43f4-b155-41619b16f219
1 parent f902f8e commit ab37961

File tree

2 files changed

+759
-740
lines changed

2 files changed

+759
-740
lines changed

python/gp/mediawiki.py

Lines changed: 22 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -183,40 +183,42 @@ def create_table ( self, ) :
183183

184184

185185

186-
def _query( self, sql ) :
187-
if ( self.big ): return self.glue.mysql_unbuffered_query(sql)
188-
else: return self.glue.mysql_query(sql)
186+
def _query( self, sql, **kwargs ) :
187+
if not 'unbuffered' in kwargs:
188+
kwargs['unbuffered'] = self.big
189+
190+
return self.glue.mysql_query(sql, **kwargs) #TODO: port kwargs to PHP
189191

190-
def _update( self, sql ) : #TODO: port to PHP; use in PHP!
191-
return self.glue.mysql_update(sql)
192+
def _update( self, sql, **kwargs ) : #TODO: port to PHP; use in PHP!
193+
return self.glue.mysql_update(sql, **kwargs)
192194

193-
def add_from_select ( self, select ) :
195+
def add_from_select ( self, select, comment = None ) :
194196
sql= "REPLACE INTO " + self.table + " "
195197
sql += "( "
196198
sql += self.id_field + ", "
197199
sql += self.namespace_field + ", "
198200
sql += self.title_field + " ) "
199201
sql += select
200202

201-
return self._update( sql )
203+
return self._update( sql, comment = comment )
202204

203205

204-
def delete_where ( self, where ) :
206+
def delete_where ( self, where, comment = None ) :
205207
sql= "DELETE FROM " + self.table + " "
206208
sql += where
207209

208-
return self._update( sql )
210+
return self._update( sql, comment = comment )
209211

210212

211-
def delete_using ( self, using, tableAlias = "T" ) :
213+
def delete_using ( self, using, tableAlias = "T", comment = None ) :
212214
sql= "DELETE FROM " + tableAlias + " "
213215
sql += "USING " + self.table + " AS " + tableAlias + " "
214216
sql += using
215217

216-
return self._update( sql )
218+
return self._update( sql, comment = comment )
217219

218220

219-
def resolve_ids ( self, ) :
221+
def resolve_ids ( self, comment = None ) :
220222
#NOTE: MySQL can't perform self-joins on temp tables. so we need to copy the ids to another temp table first.
221223
t = MySQLTable("?", "page_id")
222224
t.add_key_definition("PRIMARY KEY (page_id)")
@@ -234,7 +236,7 @@ def resolve_ids ( self, ) :
234236
sql += " FROM " + self.glue.wiki_table("page") + " AS P "
235237
sql += " JOIN " + tmp.get_name() + " AS T ON T.page_id = P.page_id"
236238

237-
self.add_from_select( sql )
239+
self.add_from_select( sql, comment = comment ) #TODO: port comment to PHP
238240

239241
self.glue.drop_temp_table( tmp )
240242
return True
@@ -430,7 +432,7 @@ def add_page_id ( self, id ) :
430432
return True
431433

432434

433-
def expand_categories ( self, ns = None ) :
435+
def expand_categories ( self, ns = None, comment = None ) :
434436
#NOTE: MySQL can't perform self-joins on temp tables. so we need to copy the category names to another temp table first.
435437
t = MySQLTable("?", "cat_title")
436438
t.set_field_definition("cat_title", "VARCHAR(255) BINARY NOT NULL")
@@ -460,7 +462,7 @@ def expand_categories ( self, ns = None ) :
460462

461463

462464
#self.glue.dump_query(sql)
463-
self.add_from_select( sql )
465+
self.add_from_select( sql, comment = comment ) #TODO: port comment to PHP
464466

465467
#self.glue.dump_query("select * from " +self.table)
466468
self.glue.drop_temp_table( tmp )
@@ -501,19 +503,19 @@ def get_size(self):
501503

502504
return row[0]
503505

504-
def add_pages_in ( self, cat, ns, depth ) :
506+
def add_pages_in ( self, cat, ns, depth, comment = None ) :
505507
self.get_size()
506508

507509
if ( not self.add_subcategories(cat, depth) ):
508510
return False
509511

510-
self.get_size()
512+
self.get_size() # ?!
511513

512-
self.expand_categories(ns)
514+
self.expand_categories(ns, comment = comment)
513515
return True
514516

515517

516-
def add_pages_transclusing ( self, tag, ns = None ) :
518+
def add_pages_transclusing ( self, tag, ns = None, comment = None ) :
517519
if ( ns is None ): ns = NS_TEMPLATE
518520
tag = self.glue.get_db_key( tag )
519521

@@ -524,7 +526,7 @@ def add_pages_transclusing ( self, tag, ns = None ) :
524526
sql += " WHERE tl_namespace = %i" % int(ns)
525527
sql += " AND tl_title = " + self.glue.quote_string(tag)
526528

527-
return self.add_from_select(sql)
529+
return self.add_from_select(sql, comment = comment)
528530

529531

530532
def clear ( self, ) :

0 commit comments

Comments
 (0)