Remove broken optional debug feature #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@adrianlang @snaterlicious @Danweetz |
mariushoch
added a commit
that referenced
this pull request
Jul 22, 2014
Remove broken optional debug feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the broken test and discussion in #43. The problem is that the original "named function" code is just wrong but the proper fix (the one in #43) is not compatible with PhantomJS yet. We (@tobijat, @mariushoch) decided it's better to remove this feature for now. It's an optional (!) debugging (!) feature anyway. #43 should be kept, rebased and merged when PhantomJS got an update some day (see ariya/phantomjs#10522).