chore: upgrade dependencies and add lockfile #135
Conversation
micgro42
requested review from
a team,
Ladsgroup,
addshore,
lucaswerkmeister and
tarrow
The lockfile is needed for npm audit to analyze the packages that will be installed. The major version upgrade to eslint was done to resolve a warning in the latest Dependabot mail. Removed all the outdated nodejs versions.
micgro42
force-pushed
the
upgradeDependencies-2021-06
branch
from
7e62d2d to
9c3c626
Compare
lucaswerkmeister
left a comment
lucaswerkmeister
left a comment
There was a problem hiding this comment.
LGTM, but I don’t want to merge it myself since I added one commit. (Also, Travis hasn’t finished testing that commit yet.)
I wonder: is that even a library that is intended to run on Nodejs? Isn't this usually a dependency of client-side JavaScript? |
Yes, but I thought it was still worth mentioning – since we apparently test the library on Node.js, it seems at least possible that others might also be using it there. But we could rephrase the release notes entry if you want. |
I was more thinking about: Should we add support/testing for the other LTS releases? 12, 14, maybe 16? |
|
I added a draft PR: #136 |
|
Travis seems to like it. I like it too :) not sure if it means we’d “officially” support those Node versions, but it seems useful to know in advance if something would break (we can’t test on Node v10 forever). |
Add support for all current Node LTS versions
|
From my point of view, this is now good to go 👍 |
The lockfile is needed for npm audit to analyze the packages that will
be installed.
The major version upgrade to eslint was done to resolve a warning in the
latest Dependabot mail.