Fix misplaced done() calls in tests #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krinkle
reviewed
Oct 10, 2017
|
|
||
| done(); | ||
| } ) | ||
| .fail( function( errorMessage ) { |
There was a problem hiding this comment.
Looks like it could use .always( done ) instead. If you place the callback (only) in done(), then the test should indeed fail still, but it would fail from a timeout, which might be confusing.
Contributor
Author
There was a problem hiding this comment.
Yea, this is much better. Thanks!
Bug: T177764
thiemowmde
force-pushed
the
qUnit2Compat
branch
from
8f908eb to
8412642
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: T177764