Remove unused globeCoordinate.Formatter #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
thiemowmde
force-pushed
the
removeCoordFormatter
branch
from
511a735 to
82b8e66
Compare
lucaswerkmeister
force-pushed
the
removeCoordFormatter
branch
from
82b8e66 to
524ca27
Compare
Contributor
|
So did you rebase on top of #122? |
Member
|
I rebased just now, but build is still failing. |
Member
|
It works if I restore some tiny diff --git a/karma.conf.js b/karma.conf.js
index 95c56453bc..d471843d20 100644
--- a/karma.conf.js
+++ b/karma.conf.js
@@ -5,6 +5,7 @@ module.exports = function ( config ) {
files: [
'node_modules/jquery/dist/jquery.js',
'lib/util/util.inherit.js',
+ 'lib/globeCoordinate/globeCoordinate.js',
'lib/globeCoordinate/globeCoordinate.GlobeCoordinate.js',
'src/dataValues.js',
'src/DataValue.js',
diff --git a/lib/globeCoordinate/globeCoordinate.js b/lib/globeCoordinate/globeCoordinate.js
new file mode 100644
index 0000000000..b3bc44fd43
--- /dev/null
+++ b/lib/globeCoordinate/globeCoordinate.js
@@ -0,0 +1 @@
+this.globeCoordinate = {}; |
Contributor
Author
|
Yea, that module was used as a namespace definition. I think restoring it like you suggested is the most easy solution for now. |
lucaswerkmeister
force-pushed
the
removeCoordFormatter
branch
from
524ca27 to
424e3b2
Compare
lucaswerkmeister
approved these changes
Oct 6, 2017
Member
lucaswerkmeister
left a comment
lucaswerkmeister
left a comment
There was a problem hiding this comment.
LGTM, but I don’t want to merge since I was the last one to push, and I’m not quite sure about the doc comment on globeCoordinate.
Contributor
|
It's not WIP anymore, right? |
Member
|
Not anymore, I think, yes. |
lucaswerkmeister
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is blocked by #122
and https://gerrit.wikimedia.org/r/371209, and must be rebased after #122 is merged.Bug: T172916