Skip to content

Restore TimeValue.getYear still used by ValueView #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ladsgroup merged 1 commit into from
Aug 4, 2017
Merged

Restore TimeValue.getYear still used by ValueView #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DataValuesJavaScript.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
return 1;
}

define( 'DATA_VALUES_JAVASCRIPT_VERSION', '0.8.4' );
define( 'DATA_VALUES_JAVASCRIPT_VERSION', '0.9.0' );

// Include the composer autoloader if it is present.
if ( is_readable( __DIR__ . '/vendor/autoload.php' ) ) {
Expand Down
5 changes: 5 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ On [Packagist](https://packagist.org/packages/data-values/javascript):

## Release notes

### 0.9.0 (dev)
* Deprecated `dataValues.TimeValue.getYear`.
* Removed `dataValues.TimeValue.getMonth`, `getDay`, `getHour`, `getMinute`, and `getSecond`.
* Made `globeCoordinate.GlobeCoordinate.getDecimal` private.

### 0.8.4 (2017-07-18)
* Updated JSDoc tags mistakenly requiring objects.
* Removed an unused dependency on `composer/installers`.
Expand Down
10 changes: 10 additions & 0 deletions src/values/TimeValue.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,16 @@ var SELF = dv.TimeValue = util.inherit( 'DvTimeValue', PARENT, function( timesta
return this.toJSON();
},

/**
* @since 0.7
* @deprecated since 0.9
*
* @return {string}
*/
getYear: function() {
return /^[+-]\d+/.exec( this.timestamp )[0];
},

/**
* @inheritdoc
*/
Expand Down