Remove unused getters from TimeValue #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiemowmde
force-pushed
the
timeValueGetters
branch
from
6bfbd4b to
7040bee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getYear,getMonth, and so on are all unused. Instead I store the wholetimestampstring now.I keep the parsing and rebuilding that was done before in the
getTimestampmethod, even if I believe this is unused. This class is used to store values as they are coming from the backend. These values should always be in a strictly fixed format. But it's hard to prove this. At least the padding of the year must be flexible.Note that
getSortKeywill be removed with #115. If this is done this code can be simplified even further, I believe, to the point where we just get rid of thepadfunction.