Remove composer/installers dependency #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Ugh, long ago :) I don't quire remember what was going on here, but if IIRC, then this stuff is needed for packages with type "mediawiki-extension", so they get installed on the location expected for extensions. Looking at |
Contributor
|
Looks like there is a conflict? I'd be happy to merge this otherwise! |
Contributor
Author
|
Conflicted because of #111. Manually rebased now. |
Contributor
|
We will need a new release in order for this to be able to get pulled into mediawiki/vendor. |
Contributor
Author
|
Please merge #113 for a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced with 75343a8 by @JeroenDeDauw. I tried to understand why, but can't figure it out. The component consists of nothing but a series of
…Installerclasses, including aMediaWikiInstallerone. I can't find usages of these classes, neither today not back then when the dependency was introduced.Either this was added by mistake, or (more likely) I'm missing something. @JeroenDeDauw, can you please have a look?