Merge pull request #131 from wmde/qUnit2Compat

Ladsgroup · web-flow · commit a195b5c45b5a · 2017-10-11T11:08:25.000+02:00
Fix misplaced done() calls in tests
diff --git a/tests/src/valueFormatters/valueFormatters.tests.js b/tests/src/valueFormatters/valueFormatters.tests.js
@@ -98,7 +98,6 @@
 					inputDetailMsg = typeof formatInput === 'string'
 						? 'for input "' + formatInput + '" '
 						: '',
-					request,
 					done = assert.async();
 
 				if( $.isArray( expected ) ) {
@@ -136,16 +135,14 @@
 						'Returned DataValue ' + inputDetailMsg + 'is equal to the expected '
 							+ 'DataValue.'
 					);
-
 				} )
 				.fail( function( errorMessage ) {
 					assert.ok(
 						false,
 						'Formatting ' + inputDetailMsg + 'failed: ' + errorMessage
 					);
-				} );
-
-				done();
+				} )
+				.always( done );
 			} );
 		}
 
diff --git a/tests/src/valueParsers/valueParsers.tests.js b/tests/src/valueParsers/valueParsers.tests.js
@@ -124,9 +124,8 @@
 					} )
 					.fail( function( errorMessage ) {
 						assert.ok( false, 'parsing ' + inputDetailMsg + 'failed: ' + errorMessage );
-					} );
-
-				done();
+					} )
+					.always( done );
 			} );
 		}
 
