Fix jquery deprecations

Ladsgroup · Ladsgroup · commit 1c048866e1fb · 2021-07-10T00:18:10.000+02:00
Bug: T280944
diff --git a/src/valueParsers/ValueParserStore.js b/src/valueParsers/ValueParserStore.js
@@ -9,7 +9,7 @@
  * @throws {Error} if the provided argument is not a valueParsers.ValueParser constructor.
  */
 function assertIsValueParserConstructor( Parser ) {
-	if( !( $.isFunction( Parser ) && Parser.prototype instanceof vp.ValueParser ) ) {
+	if( !( typeof Parser === 'function' && Parser.prototype instanceof vp.ValueParser ) ) {
 		throw new Error( 'Invalid ValueParser constructor' );
 	}
 }
diff --git a/tests/src/dataValues.DataValue.tests.js b/tests/src/dataValues.DataValue.tests.js
@@ -84,7 +84,7 @@
 			var self = this;
 
 			$.each( this, function( property, value ) {
-				if ( property.substring( 0, 4 ) === 'test' && $.isFunction( self[property] ) ) {
+				if ( property.substring( 0, 4 ) === 'test' && typeof self[property] === 'function' ) {
 					QUnit.test(
 						property,
 						function( assert ) {
@@ -137,7 +137,7 @@
 			var fnNewFromJSON = this.getConstructor().newFromJSON;
 
 			assert.ok(
-				$.isFunction( fnNewFromJSON ),
+				typeof fnNewFromJSON === 'function',
 				'has a related newFromJSON function'
 			);
 		},
diff --git a/tests/src/dataValues.tests.js b/tests/src/dataValues.tests.js
@@ -11,7 +11,7 @@
 		var dvs = dv.getDataValues();
 		assert.expect( dvs.length * 2 + 1 );
 
-		assert.ok( $.isArray( dvs ), 'Returns an array' );
+		assert.ok( Array.isArray( dvs ), 'Returns an array' );
 
 		for ( var i = 0, s = dvs.length; i < s; i++ ) {
 			assert.ok(
diff --git a/tests/src/valueFormatters/valueFormatters.tests.js b/tests/src/valueFormatters/valueFormatters.tests.js
@@ -69,7 +69,7 @@
 			var self = this;
 
 			$.each( this, function( property, value ) {
-				if( property.substring( 0, 4 ) === 'test' && $.isFunction( self[property] ) ) {
+				if( property.substring( 0, 4 ) === 'test' && typeof self[property] === 'function' ) {
 					QUnit.test(
 						property,
 						function( assert ) {
@@ -100,7 +100,7 @@
 						: '',
 					done = assert.async();
 
-				if( $.isArray( expected ) ) {
+				if( Array.isArray( expected ) ) {
 					expectedValue = expected[0];
 					expectedDataValue = expected[1];
 				} else {
diff --git a/tests/src/valueParsers/valueParsers.tests.js b/tests/src/valueParsers/valueParsers.tests.js
@@ -75,7 +75,7 @@
 			var self = this;
 
 			$.each( this, function( property, value ) {
-				if ( property.substring( 0, 4 ) === 'test' && $.isFunction( self[property] ) ) {
+				if ( property.substring( 0, 4 ) === 'test' && typeof self[property] === 'function' ) {
 					QUnit.test(
 						property,
 						function( assert ) {

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`	`* @throws {Error} if the provided argument is not a valueParsers.ValueParser constructor.`
`10`	`10`	`*/`
`11`	`11`	`function assertIsValueParserConstructor( Parser ) {`
`12`		`- if( !( $.isFunction( Parser ) && Parser.prototype instanceof vp.ValueParser ) ) {`
	`12`	`+ if( !( typeof Parser === 'function' && Parser.prototype instanceof vp.ValueParser ) ) {`
`13`	`13`	`throw new Error( 'Invalid ValueParser constructor' );`
`14`	`14`	`}`
`15`	`15`	`}`