Removing setuptools dependency on build#62
Conversation
|
Good catch! Yes, that should be replaced with 'poetry install'. I'll update the PR |
|
@oleg-nenashev I just updated the PR, but note that the command noted on the screenshot is not what's used to build the docs, but just a reference on how to install wiremock. I replaced that with a #!/bin/bash
sphinx-build docs html
watchmedo shell-command -R --command 'sphinx-build docs html' ./docs/ |
|
@jmdacruz Can we go ahead and remove the setup.py file now? |
|
@gyoganathan we could, but the file currently doesn't influence the build using "Python -m build --sdist", meaning that the build using poetry does not depend on the "setup.py" file at all. I'll let the authors decide if we should remove it in this PR |
With the use of `pyproject.toml` and tools such as `poetry`, there's no need to use `setuptools` and `setup.py` to build the distribution
|
@oleg-nenashev I went ahead and removed |
oleg-nenashev
left a comment
There was a problem hiding this comment.
Yes, thanks a lot! We can always restore it from the commit history should be needed
|
@oleg-nenashev got your approval, but I can't merge yet. Do we need some other approval? |
|
Generally needs @mikeywaites to merge it as a maintainer |

With the use of modern build tools such as
pyproject.tomlandpoetry, there's no need to usesetuptoolsandsetup.pyto build the distribution