Fixed Qt scripts/launchers for pyqt5_tools 5.15 #881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed batch scripts (and exe launchers) for Qt Assistant, Designer and Linguist. Requires pyqt5_tools 5.15.
Contributor
|
small question. Do you trust ?
|
Contributor
Author
|
What do you mean? |
Contributor
|
do you consider it a safe source for Qt binaries ? As it's a new source of Qt binaries outside of Qt itself (Pyside2) and riverbankcomputing (PyQt5), and cgohlke |
Contributor
Author
|
The only thing I can tell is that the author seems quite implicated in OSS. The question is: is it a good idea to ship pyqt5_tools with WinPython? (60MB!) It depends if we want to the exe launchers (Qt Assistant, and so on) to work again or not, I guess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed batch scripts (and exe launchers) for Qt Assistant, Designer and Linguist.
Requires pyqt5_tools 5.15.