Skip to content

fix wppm -p pkg[.] showing only the last extra, and make -p -l0 a true one-liner - #2059

Merged
stonebig merged 1 commit into
winpython:masterfrom
stonebig:master
Jul 16, 2026
Merged

stonebig merged 1 commit into
winpython:masterfrom
stonebig:master

Conversation

@stonebig

Copy link
Copy Markdown
Contributor

summary:

  • down(): the results accumulation had moved outside the per-extra loop, so only the alphabetically last extra was displayed
  • wppm -p -l0 now means depth 0 like wppm -r -l0 (was silently depth 2)
  • missing-dependency '==?' lines now respect the requested depth
  • bump wppm version to 17.7.20260716

bugs were not from Claude but previous human:

  • for the "pandas[.]" showing only 1 extra, it's

The bug: commit 5114738 ("display missing dependancies") restructured down() in wppm/piptree.py so it could filter results for the new ! mode, but it moved the results += ... line outside the for one_extra in sorted(self.distro[p]["provides"]) loop. Each iteration overwrote a, and only the last extra in alphabetical order (xml for pandas) was appended to the output. It affected only -p with [.]; up() (-r) kept its accumulation inside the loop, which is why your reverse test was fine.

The fix: moved results += a if (len(a[0])>1 or ppend=="") else [] back inside the loop (and duplicated it in the else branch), at piptree.py:268-275.

One side note from the verification output: the ==? "missing dependency" lines show up even at -l0, since they're emitted at the current level rather than as a recursion — that's the new feature from 5114738 behaving as designed, just mentioning it in case you expected -l0 to stay one-line-per-extra.
  • for "wppm -p pandas -l0" not showing one line:
    • it was like that since june 2025
    • so having Claude caring of code gives more time to worry on result... if you are still in [needed] perseverance mode.

…e one-liner

- down(): the results accumulation had moved outside the per-extra loop,
  so only the alphabetically last extra was displayed
- wppm -p -l0 now means depth 0 like wppm -r -l0 (was silently depth 2)
- missing-dependency '==?' lines now respect the requested depth
- bump wppm version to 17.7.20260716

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@stonebig
stonebig merged commit 8fa7aeb into winpython:master Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant