Skip to content

remove un-needed documentation_directories_list() complexity #1519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stonebig merged 1 commit into from
Mar 23, 2025
Merged

remove un-needed documentation_directories_list() complexity #1519

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions make.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def find_7zip_executable() -> str:
possible_program_files = [
Path(r"C:\Program Files"),
Path(r"C:\Program Files (x86)"),
Path(sys.prefix).parent / "t" ,
Path(sys.prefix).parent / "t",
]
for base_dir in possible_program_files:
if (executable_path := base_dir / "7-Zip" / "7z.exe").is_file():
Expand Down Expand Up @@ -291,13 +291,6 @@ def pre_path_entries(self) -> list[str]:
r".." + self.NODEJS_RELATIVE_PATH,
]

@property
def documentation_directories_list(self) -> list[Path]:
"""Returns the list of documentation directories to include."""
if (default_docs_directory := Path(__file__).parent / "docs").is_dir():
return [default_docs_directory] + self.documentation_directories
return self.documentation_directories

def create_installer_7zip(self, installer_type: str = ".exe"):
"""Creates a WinPython installer using 7-Zip: ".exe", ".7z", ".zip")"""
self._print_action(f"Creating WinPython installer ({installer_type})")
Expand Down Expand Up @@ -347,7 +340,7 @@ def _copy_essential_files(self):

docs_target_directory = self.winpython_directory / "notebooks" / "docs"
self._print_action(f"Copying documentation to {docs_target_directory}")
_copy_items(self.documentation_directories_list, docs_target_directory, self.verbose)
_copy_items(self.documentation_directories, docs_target_directory, self.verbose)

tools_target_directory = self.winpython_directory / "t"
self._print_action(f"Copying tools to {tools_target_directory}")
Expand Down