Feature: Add session deletion functionality#363
Open
iFlyTwice wants to merge 1 commit intowinfunc:mainfrom
Open
Feature: Add session deletion functionality#363iFlyTwice wants to merge 1 commit intowinfunc:mainfrom
iFlyTwice wants to merge 1 commit intowinfunc:mainfrom
Conversation
Implements session deletion feature with delete button on hover for each session card. Addresses issue winfunc#305 where users requested the ability to delete unnecessary sessions. ## Changes: - **Backend**: Added Rust command to remove .jsonl files and associated todo data - **Frontend**: Added API method with proper error handling - **UI**: Added Trash2 icon delete button that appears on session card hover - **UX**: Added confirmation dialog before deletion to prevent accidents - **State**: Updated local state management to remove sessions immediately after deletion ## Features: - Hover-to-reveal delete button for clean UI - Confirmation dialog with session details - Deletes both session file and associated todo data - Proper error handling and user feedback - Follows project coding standards and documentation guidelines Fixes winfunc#305
Author
|
W UI |
Member
Review
Required fixes
Follow-ups
|
Member
|
@claude review this |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements session deletion feature with delete button on hover for each session card.
Addresses issue #305 where users requested the ability to delete unnecessary sessions.
Changes:
delete_sessionRust command to remove .jsonl files and associated todo datadeleteSessionAPI method with proper error handlingFeatures:
Testing:
Fixes #305