Ignore ssl and add test to detect a working ssl connection

uvchik · uvchik · commit 60f58ce76555 · 2021-01-19T15:21:30.000+01:00
diff --git a/tests/test_data_handling.py b/tests/test_data_handling.py
@@ -9,6 +9,7 @@
 
 import pandas as pd
 import pytest
+import requests
 from windpowerlib.data import (
     check_data_integrity,
     check_turbine_data,
@@ -101,6 +102,23 @@ def test_wrong_url_load_turbine_data(self):
         ):
             store_turbine_data_from_oedb("wrong_schema")
 
+    def test_wrong_ssl_connection(self):
+        """Test failing ssl connection. To avoid this error in data.py the in
+        the function fetch_turbine_data_from_oedb in data.py verify was set
+        to False to ignore the exception in the requests statement.
+
+        If this test fails you can set verify to True and remove this test if
+        all the other tests work fine.
+        """
+        schema = "supply"
+        table = "wind_turbine_library"
+        oep_url = "https://oep.iks.cs.ovgu.de/"
+        url = oep_url + "/api/v0/schema/{}/tables/{}/rows/?".format(
+            schema, table
+        )
+        with pytest.raises(requests.exceptions.SSLError):
+            requests.get(url, verify=True)
+
     def test_restore_default_data(self):
         """Test the clean recovery of the data files."""
         names = ["turbine_data", "power_curves", "power_coefficient_curves"]
diff --git a/windpowerlib/data.py b/windpowerlib/data.py
@@ -133,11 +133,11 @@ def fetch_turbine_data_from_oedb(
 
     """
     # url of OpenEnergy Platform that contains the oedb
-    oep_url = "http://oep.iks.cs.ovgu.de/"
+    oep_url = "https://oep.iks.cs.ovgu.de/"
     url = oep_url + "/api/v0/schema/{}/tables/{}/rows/?".format(schema, table)
 
     # load data
-    result = requests.get(url)
+    result = requests.get(url, verify=False)
     if not result.status_code == 200:
         raise ConnectionError(
             "Database (oep) connection not successful. \nURL: {2}\n"
