Add integration suite, sample.env, and update example docs #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit includes the following changes: - Added more information to batches README on example usage, and expected output. - Tweaked batches.py to reflect the README changes. - Added more information to clientconfig README on example usage, and expected output. - Tweaked clientconfig.py to reflect the README changes. - Added more information to metadata README on example usage, and expected output. - Tweaked metadata.py to reflect the README changes. - Added more information to snapshots README on example usage, and expected output. - Tweaked snapshots.py to reflect the README changes. - Added a new integration test suite. - Added a sample.env file to ensure users have a .env file when first downloading the SDK.
jaleman-vdr-wikimedia
added
documentation
| @@ -0,0 +1,3 @@ | |||
| WME_USERNAME= | |||
| WME_PASSWORD= | |||
| PYTHONPATH=. | |||
Contributor
There was a problem hiding this comment.
Why do we need to set the python path?
Contributor
Author
There was a problem hiding this comment.
This was part of an idea I had to provide flexibility to the user to run the script from anywhere, but it didn't quite work out! I've since removed it!
jaleman-vdr-wikimedia
merged commit 50b9433
into
wikimedia-enterprise:main
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit includes the following changes:
Added more information to batches README on example usage, and expected output.
Tweaked batches.py to reflect the README changes.
Added more information to clientconfig README on example usage, and expected output.
Tweaked clientconfig.py to reflect the README changes.
Added more information to metadata README on example usage, and expected output.
Tweaked metadata.py to reflect the README changes.
Added more information to snapshots README on example usage, and expected output.
Tweaked snapshots.py to reflect the README changes.
Added a new integration test suite.
Added a sample.env file to ensure users have a .env file when first downloading the SDK.