This repository was archived by the owner on Aug 19, 2025. It is now read-only.
Atom: Makes sure to escape '&' #397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DOMDocument::createElement escapes '<' and '>' but not '&'...
samwilson
reviewed
Feb 14, 2022
| } | ||
|
|
||
| $node = $dom->createElement( $name, $value ); | ||
| $node = $dom->createElement( $name, str_replace( '&', '&', $value ) ); |
Member
There was a problem hiding this comment.
Actually, I think another way to do this might be to set textContent directly, e.g.:
$node = $dom->createElement( $name );
$node->textContent = $value;I'm not sure if there are other considerations, so probably it's fine to handle the one-off case you've found.
Collaborator
Author
There was a problem hiding this comment.
It sounds much better. Thank you! I create #398 to do it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOMDocument::createElement escapes '<' and '>' but not '&'...