Adding jsr305 annotations.

Guillaume Lederrey · Guillaume Lederrey · commit 6bc6bf85c19f · 2022-07-19T15:03:28.000+02:00
Adding annotations so that paramters are non null by
default and tagging methods appropriately.

Change-Id: Iccb6fde3022f0add1aedaac9112d8ebb236141bc
diff --git a/http-client-utils/src/main/java/org/wikimedia/utils/http/CustomRoutePlanner.java b/http-client-utils/src/main/java/org/wikimedia/utils/http/CustomRoutePlanner.java
@@ -5,13 +5,17 @@
 
 import java.util.Map;
 
+import javax.annotation.Nonnull;
+import javax.annotation.ParametersAreNonnullByDefault;
+
 import org.apache.http.HttpException;
 import org.apache.http.HttpHost;
 import org.apache.http.HttpRequest;
 import org.apache.http.conn.routing.HttpRoute;
 import org.apache.http.conn.routing.HttpRoutePlanner;
 import org.apache.http.protocol.HttpContext;
 
+@ParametersAreNonnullByDefault
 public class CustomRoutePlanner implements HttpRoutePlanner {
 
     private final Map<String, HttpHost> customRouteMap;
@@ -27,6 +31,7 @@ public CustomRoutePlanner(Map<String, HttpHost> customRouteMap, HttpRoutePlanner
      * separated by commas with no space between them
      * for example: www.wikidata.org=http://proxy.local:9999,www.metawiki.org=https://proxy.local:8080
      */
+    @Nonnull
     public static Map<String, HttpHost> createMapFromString(String mapProxyProperty) {
         String[] pairs = mapProxyProperty.split(",");
         return stream(pairs).map(p -> p.split("=")).
@@ -37,7 +42,7 @@ public void addRoute(String sourceURL, String targetURL) {
         customRouteMap.put(sourceURL, HttpHost.create(targetURL));
     }
 
-    @Override
+    @Override @Nonnull
     public HttpRoute determineRoute(HttpHost httpHost, HttpRequest httpRequest, HttpContext httpContext) throws HttpException {
         HttpHost destHost = customRouteMap.get(httpHost.getHostName());
         if (destHost != null) {
