-
-
Notifications
You must be signed in to change notification settings - Fork 831
Talk Page Archives - Part 2 #4446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ikipedia-ios into talk-page-archives-2
mazevedofs
approved these changes
Jan 23, 2023
Collaborator
mazevedofs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The shifting view is looking great! I believe you're considering Deepak's feedback for part 3, so I'm not considering it for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator:
https://phabricator.wikimedia.org/T321853
Notes
This mostly wraps up the Talk Page Archives feature. Most of these commits are feature-specific logic, but a few towards the end dip back into adding abilities to the shifting top views setup (shadow behavior, loading, flicking).
There are a few things for me to look into from Part 1 PR feedback. I'll look into these in a Part 3 PR.
At the end I added the ability for the navigation bar to reappear when the user flicks back up, to try to build in more functionality from elsewhere in the app. It did turn into some gnarly state code that still doesn't quite feel 100%. I'm also not sure if it even makes sense on this particular screen since the Talk Pages bar doesn't scroll out of view. As of now I feel like the work is worth keeping than scrapping, but I'm open to reverting 1208684 if reviewers disagree.
Test Steps