Add MetricsClientBridge for Objective-C compatibility #3991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splits the EventPlatformClient's Objective-C compatilibity layer into a bridging class which will remain in the app repository after the client library is consolidated with the other platform libraries as part of the work falling under T280182. This is needed because the standalone Swift client library will need to run on Linux, where the `@objc` annotation providing interoperability is not supported. The bridging class will likely also be used to expose main app functionality to the client library once the library itself is extracted. Note: Metrics Client is the new name for the Event Platform Client project.
tonisevener
reviewed
Jul 26, 2021
Collaborator
tonisevener
left a comment
tonisevener
left a comment
There was a problem hiding this comment.
@mdholloway This looks good! Just one small ask about MetricsClientObjectiveCCompat.
|
|
||
| // MARK: Objective-C | ||
|
|
||
| public protocol MetricsClientObjectiveCCompat: BackgroundFetcher, PeriodicWorker { |
Collaborator
There was a problem hiding this comment.
It doesn't look like this protocol is used anywhere, can you remove it? Your extensions in MetricsClientBridge.swift should be enough to conform to BackgroundFetcher and PeriodicWorker.
tonisevener
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits the EventPlatformClient's Objective-C compatilibity layer into a bridging class which will remain in the app repository after the client library is consolidated with the other platform libraries as part of the work falling under T280182. This is needed because the standalone Swift client library will need to run on Linux, where the
@objcannotation providing interoperability is not supported.The bridging class will likely also be used to expose main app functionality to the client library once the library itself is extracted.
Note: Metrics Client is the new name for the Event Platform Client project.