Skip to content

Event logging client for (Modern) Event Platform #3648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tonisevener merged 56 commits into from
Sep 14, 2020
Merged

Event logging client for (Modern) Event Platform #3648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
66c7de5
Event logging client for (Modern) Event Platform
bearloga Jul 30, 2020
ab60d39
add EPCStorageManager + tests
tonisevener Jul 31, 2020
c3350cb
initial work on EPCNetworkManager
tonisevener Jul 31, 2020
b351b0f
finish NetworkManager, add tests
tonisevener Aug 4, 2020
6ad7cdf
Remove stream cc-ing feature from Event Platform Client
bearloga Aug 4, 2020
96a554b
finished integration + a couple of sample calls
tonisevener Aug 4, 2020
d57ab1d
Update EPC for actual stream configs format
bearloga Aug 4, 2020
0065eac
some renames and code cleanup
tonisevener Aug 5, 2020
5dd634d
Merge branch 'event-platform-client' into epc-integration
tonisevener Aug 5, 2020
08b799e
undo warning fix
tonisevener Aug 5, 2020
0f496a2
add some test logging
tonisevener Aug 5, 2020
8d8eea8
Merge branch 'main' into event-platform-client
tonisevener Aug 5, 2020
431870f
More documentation for EPC & helpers, fix stream config processing
bearloga Aug 7, 2020
47dae16
Event Platform Client: sync ID generation algo to MediaWiki's
bearloga Aug 17, 2020
40cfa5f
Event Platform Client: some more polish
bearloga Aug 19, 2020
6799de1
Merge branch 'main' into event-platform-client
joewalsh Aug 19, 2020
8d18452
Fix tests, deviceID was renamed to installID
joewalsh Aug 20, 2020
079d807
T260382: Edit History Compare instrumentation with EPC
bearloga Aug 21, 2020
267984a
EditHistoryCompareFunnel: remove extraneous EPC log call
bearloga Aug 21, 2020
675e056
[Minor] EditHistoryCompareFunnel: remove unnecessary comparison
bearloga Aug 21, 2020
a8d78c0
EPC: clarification about domain, absoluteString => host
bearloga Aug 21, 2020
a563d4c
Merge branch 'main' into event-platform-client
joewalsh Aug 25, 2020
0699c3e
MEP test events update
bearloga Aug 27, 2020
9be85f1
EPC: Begin stashing storage mng facilities for later
bearloga Aug 28, 2020
5553d47
Rest of EPCStorageManager clean-up
bearloga Aug 31, 2020
70d420c
EPC: More cleaning up/finalizing
bearloga Sep 2, 2020
739336c
EPC: Consolidation of networking into main library
bearloga Sep 3, 2020
e1a33e1
Update EventPlatformClientLibrary.swift
bearloga Sep 3, 2020
1efb428
Store body data in the buffer instead of an NSDictionary
joewalsh Sep 9, 2020
a3b74cb
codable EPC WIP
joewalsh Sep 9, 2020
d5e811c
Codable events
joewalsh Sep 9, 2020
8e46326
Events should conform to EventInterface
joewalsh Sep 9, 2020
2c0d4bc
Use the value from popFirst instead of checking isEmpty
joewalsh Sep 9, 2020
8afbb4c
Encode data on a background queue
joewalsh Sep 9, 2020
41c36e1
Use Codable for stream configurations
joewalsh Sep 9, 2020
8133bce
Fix missing completion call in doPeriodicWork
joewalsh Sep 9, 2020
aa95f15
Use stream instead of String as the key
joewalsh Sep 9, 2020
ea52390
Remove Dictionary+JSON
joewalsh Sep 9, 2020
c5f057a
Merge branch 'main' into event-platform-client
joewalsh Sep 9, 2020
06a842e
EPC: Final v1 clean-up, switch to production stream config endpoint
bearloga Sep 9, 2020
b1f831f
Merge branch 'event-platform-client' of github.com:wikimedia/wikipedi…
bearloga Sep 9, 2020
9635b93
Merge branch 'event-platform-client' of github.com:wikimedia/wikipedi…
joewalsh Sep 9, 2020
83ddec5
Remove test streams and schema
joewalsh Sep 9, 2020
c9a586b
Restore & update documentation, remove `data` property from the paylo…
joewalsh Sep 10, 2020
a68097f
Match prior log message
joewalsh Sep 10, 2020
bc63eec
Move `schema` to a static requirement on `EventInterface` so it's def…
joewalsh Sep 10, 2020
ceac06b
Log errros from EPC POSTs
joewalsh Sep 10, 2020
f336aab
Fix functionality added by bodyData parameter
joewalsh Sep 10, 2020
479c577
Restore central definition of schemas, keep per-Event static schema d…
joewalsh Sep 11, 2020
5c6e5ee
Add error handling to catch when the service rejects an event for not…
joewalsh Sep 11, 2020
a1eb285
Fix append - use event data instead of stream data
joewalsh Sep 14, 2020
991940b
Use concrete EventRequest type for event buffers
joewalsh Sep 14, 2020
6c86ad9
Remove old TODO from EditHistoryCompareFunnel
bearloga Sep 14, 2020
0299b52
Merge pull request #3682 from wikimedia/codable_epc
joewalsh Sep 14, 2020
20cf1be
Merge branch 'main' into event-platform-client
joewalsh Sep 14, 2020
62a9eb3
Remove client-facing date param, record the date synchronously
joewalsh Sep 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions WMF Framework/Dictionary+JSON.swift
View file
Open in desktop

This file was deleted.

27 changes: 27 additions & 0 deletions ...Platform Client/EventPlatformClient.xcdatamodeld/EventPlatformClient.xcdatamodel/contents
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<model type="com.apple.IDECoreDataModeler.DataModel" documentVersion="1.0" lastSavedToolsVersion="16119" systemVersion="19G73" minimumToolsVersion="Automatic" sourceLanguage="Swift" userDefinedModelVersionIdentifier="">
<entity name="EPCPost" representedClassName="EPCPost" syncable="YES">
<attribute name="body" attributeType="Transformable" valueTransformerName=""/>
<attribute name="failed" attributeType="Boolean" defaultValueString="NO" usesScalarValueType="YES"/>
<attribute name="posted" optional="YES" attributeType="Date" usesScalarValueType="NO"/>
<attribute name="recorded" attributeType="Date" usesScalarValueType="NO"/>
<attribute name="url" attributeType="URI"/>
<attribute name="userAgent" attributeType="String"/>
<fetchIndex name="byRecordedIndex">
<fetchIndexElement property="recorded" type="Binary" order="ascending"/>
</fetchIndex>
</entity>
<entity name="WMFKeyValue" representedClassName="WMFKeyValue" syncable="YES">
<attribute name="date" optional="YES" attributeType="Date" usesScalarValueType="NO"/>
<attribute name="group" optional="YES" attributeType="String"/>
<attribute name="key" attributeType="String"/>
<attribute name="value" attributeType="Transformable" valueTransformerName=""/>
<fetchIndex name="byKeyIndex">
<fetchIndexElement property="key" type="Binary" order="ascending"/>
</fetchIndex>
</entity>
<elements>
<element name="EPCPost" positionX="-54" positionY="18" width="128" height="133"/>
<element name="WMFKeyValue" positionX="-36" positionY="63" width="128" height="103"/>
</elements>
</model>
26 changes: 13 additions & 13 deletions WMF Framework/EventLogging.xcdatamodeld/EventLogging.xcdatamodel/contents
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,27 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<model type="com.apple.IDECoreDataModeler.DataModel" documentVersion="1.0" lastSavedToolsVersion="14135" systemVersion="17E202" minimumToolsVersion="Automatic" sourceLanguage="Swift" userDefinedModelVersionIdentifier="">
<model type="com.apple.IDECoreDataModeler.DataModel" documentVersion="1.0" lastSavedToolsVersion="16119" systemVersion="19G73" minimumToolsVersion="Automatic" sourceLanguage="Swift" userDefinedModelVersionIdentifier="">
<entity name="WMFEventRecord" representedClassName="WMFEventRecord" syncable="YES">
<attribute name="event" attributeType="Transformable" syncable="YES"/>
<attribute name="failed" attributeType="Boolean" defaultValueString="NO" usesScalarValueType="YES" syncable="YES"/>
<attribute name="postAttempts" attributeType="Integer 16" defaultValueString="0" usesScalarValueType="YES" syncable="YES"/>
<attribute name="posted" optional="YES" attributeType="Date" usesScalarValueType="NO" syncable="YES"/>
<attribute name="recorded" attributeType="Date" usesScalarValueType="NO" syncable="YES"/>
<attribute name="userAgent" optional="YES" attributeType="String" syncable="YES"/>
<attribute name="event" attributeType="Transformable" valueTransformerName=""/>
<attribute name="failed" attributeType="Boolean" defaultValueString="NO" usesScalarValueType="YES"/>
<attribute name="postAttempts" attributeType="Integer 16" defaultValueString="0" usesScalarValueType="YES"/>
<attribute name="posted" optional="YES" attributeType="Date" usesScalarValueType="NO"/>
<attribute name="recorded" attributeType="Date" usesScalarValueType="NO"/>
<attribute name="userAgent" optional="YES" attributeType="String"/>
<fetchIndex name="byRecordedIndex">
<fetchIndexElement property="recorded" type="Binary" order="ascending"/>
</fetchIndex>
</entity>
<entity name="WMFKeyValue" representedClassName="WMFKeyValue" syncable="YES">
<attribute name="date" optional="YES" attributeType="Date" usesScalarValueType="NO" syncable="YES"/>
<attribute name="group" optional="YES" attributeType="String" syncable="YES"/>
<attribute name="key" attributeType="String" syncable="YES"/>
<attribute name="value" optional="YES" attributeType="Transformable" syncable="YES"/>
<attribute name="date" optional="YES" attributeType="Date" usesScalarValueType="NO"/>
<attribute name="group" optional="YES" attributeType="String"/>
<attribute name="key" attributeType="String"/>
<attribute name="value" optional="YES" attributeType="Transformable" valueTransformerName=""/>
<fetchIndex name="byKeyIndex">
<fetchIndexElement property="key" type="Binary" order="ascending"/>
</fetchIndex>
</entity>
<elements>
<element name="WMFEventRecord" positionX="-63" positionY="-18" width="128" height="135"/>
<element name="WMFKeyValue" positionX="-45" positionY="36" width="128" height="105"/>
<element name="WMFEventRecord" positionX="-63" positionY="-18" width="128" height="133"/>
<element name="WMFKeyValue" positionX="-45" positionY="36" width="128" height="103"/>
</elements>
</model>
Loading