This repository was archived by the owner on Jul 30, 2020. It is now read-only.
Add OpenGraph tags and twitter meta tags for having cards when sharing in social media #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krinkle
reviewed
May 31, 2017
header.php
Outdated
| <?php if ( is_single() ) { | ||
| echo '<meta property="og:image" content="' . the_post_thumbnail( 'large' ) . '"/>'; | ||
| echo '<meta property="og:description" content="' . bloginfo( 'description' ) . '"/>'; | ||
| echo '<meta property="og:title" content="' . single_post_title() . '"/>'; |
Member
There was a problem hiding this comment.
Presumably these three values need escaping?
Also, single_post_title() echoes by default instead of returning, which means it will echo it before the current line (if understand correctly).
Krinkle
reviewed
May 31, 2017
header.php
Outdated
| <link rel="pingback" href="<?php echo esc_attr( get_bloginfo( 'pingback_url' ) ); ?>" /> | ||
| <?php if ( is_single() ) { | ||
| echo '<meta property="og:image" content="' . the_post_thumbnail( 'large' ) . '"/>'; | ||
| echo '<meta property="og:description" content="' . bloginfo( 'description' ) . '"/>'; |
Member
There was a problem hiding this comment.
bloginfo() echoes, use get_bloginfo() instead.
Krinkle
reviewed
May 31, 2017
header.php
Outdated
| <link rel="shortcut icon" href="<?php echo esc_url( get_stylesheet_directory_uri() ); ?>/images/favicon.ico" /> | ||
| <link rel="pingback" href="<?php echo esc_attr( get_bloginfo( 'pingback_url' ) ); ?>" /> | ||
| <?php if ( is_single() ) { | ||
| echo '<meta property="og:image" content="' . the_post_thumbnail( 'large' ) . '"/>'; |
Member
Author
|
Thanks for the review |
Member
Author
Contributor
|
LGTM code-wise. Waiting for legal feedback… |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would help greatly if we want to share in twitter or facebook and shows a nice little card. We already done that for Wikipedia articles and Wikidata items.
Useful links: