Add phan

reedy · reedy · commit dfdfb1c41bb0 · 2022-03-15T15:54:48.000Z
Bug: T303786
Change-Id: I8a8bfdf5bb0c116db3817bdd1aea442f0080ff93
diff --git a/.gitattributes b/.gitattributes
@@ -7,5 +7,6 @@ Doxyfile export-ignore
 composer.json export-ignore
 .phpcs.xml export-ignore
 phpunit.xml.dist export-ignore
+.phan/ export-ignore
 build/ export-ignore
 tests/ export-ignore
diff --git a/.phan/config.php b/.phan/config.php
@@ -0,0 +1,7 @@
+<?php
+
+$cfg = require __DIR__ . '/../vendor/mediawiki/mediawiki-phan-config/src/config.php';
+
+$cfg['suppress_issue_types'][] = 'PhanTypeInvalidDimOffset';
+
+return $cfg;
diff --git a/composer.json b/composer.json
@@ -23,6 +23,7 @@
 	},
 	"require-dev": {
 		"mediawiki/mediawiki-codesniffer": "38.0.0",
+		"mediawiki/mediawiki-phan-config": "0.11.1",
 		"mediawiki/minus-x": "1.1.1",
 		"ockcyp/covers-validator": "1.3.3",
 		"php-parallel-lint/php-console-highlighter": "0.5.0",
@@ -35,13 +36,15 @@
 			"phpunit",
 			"covers-validator",
 			"@phpcs",
+			"phan --allow-polyfill-parser --long-progress-bar",
 			"minus-x check ."
 		],
 		"cover": "phpunit --coverage-html coverage",
 		"fix": [
 			"minus-x fix .",
 			"phpcbf"
 		],
+		"phan": "phan --allow-polyfill-parser --long-progress-bar",
 		"phpcs": "phpcs -sp"
 	}
 }
diff --git a/src/TextCat.php b/src/TextCat.php
@@ -239,6 +239,7 @@ public function createLM( $text, $maxNgrams ) {
 	 */
 	public function loadLanguageFile( $langFile ) {
 		include $langFile;
+		// @phan-suppress-next-line PhanTypeMismatchArgumentInternal $ranks is brought in by the include
 		array_splice( $ranks, $this->maxNgrams );
 		return $ranks;
 	}

Original file line number	Diff line number	Diff line change
`@@ -239,6 +239,7 @@ public function createLM( $text, $maxNgrams ) {`
`239`	`239`	`*/`
`240`	`240`	`public function loadLanguageFile( $langFile ) {`
`241`	`241`	`include $langFile;`
	`242`	`+ // @phan-suppress-next-line PhanTypeMismatchArgumentInternal $ranks is brought in by the include`
`242`	`243`	`array_splice( $ranks, $this->maxNgrams );`
`243`	`244`	`return $ranks;`
`244`	`245`	`}`