Avoid deprecation warning for static properties

Ammarpad · Ammarpad · commit 975e89994a66 · 2023-11-28T07:57:09.000+01:00
Use ReflectionClass::setStaticPropertyValue to set static properties

Bug: T352060
Change-Id: Ifed1422cc985e608f886192224e6611477827e36
diff --git a/src/TestingAccessWrapper.php b/src/TestingAccessWrapper.php
@@ -127,7 +127,12 @@ public function __set( $name, $value ) {
 				. ': Cannot set non-static property when wrapping static class' );
 		}
 
-		$propertyReflection->setValue( $this->object, $value );
+		if ( $this->isStatic() ) {
+			$class = new ReflectionClass( $this->object );
+			$class->setStaticPropertyValue( $name, $value );
+		} else {
+			$propertyReflection->setValue( $this->object, $value );
+		}
 	}
 
 	/**

Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,12 @@ public function __set( $name, $value ) {`
`127`	`127`	`. ': Cannot set non-static property when wrapping static class' );`
`128`	`128`	`}`
`129`	`129`
`130`		`- $propertyReflection->setValue( $this->object, $value );`
	`130`	`+ if ( $this->isStatic() ) {`
	`131`	`+ $class = new ReflectionClass( $this->object );`
	`132`	`+ $class->setStaticPropertyValue( $name, $value );`
	`133`	`+ } else {`
	`134`	`+ $propertyReflection->setValue( $this->object, $value );`
	`135`	`+ }`
`131`	`136`	`}`
`132`	`137`
`133`	`138`	`/**`