Remove one last use of ReflectionProperty::setAccessible(), no-op

jdforrester · jdforrester · commit 44cfe025962a · 2025-10-09T15:04:12.000-04:00
As well as being a no-op now that we're in PHP 8.1+, these are
deprecated and will trigger errors in PHP 8.5.

Bug: T406744
Change-Id: I9860383170ae14a24d0d2f4a472ba732f3e1bb79
diff --git a/src/TestingAccessWrapper.php b/src/TestingAccessWrapper.php
@@ -217,7 +217,6 @@ private function getProperty( $name ) {
 				}
 			}
 		}
-		$propertyReflection->setAccessible( true );
 		return $propertyReflection;
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -217,7 +217,6 @@ private function getProperty( $name ) {`
`217`	`217`	`}`
`218`	`218`	`}`
`219`	`219`	`}`
`220`		`- $propertyReflection->setAccessible( true );`
`221`	`220`	`return $propertyReflection;`
`222`	`221`	`}`
`223`	`222`	`}`