Skip to content

Conversation

@mvolz
Copy link
Collaborator

@mvolz mvolz commented Nov 10, 2020

Update linting packages

  • Add rule overrides for two rules which aren't trivially fixable (no-shadow, jsdoc/no-undefined-types)
  • Fix rule fixable with eslint --fix (add blank line in jsdoc blocks after description)
  • Remove extends/rules now included upstream in wikimedia/server
  • Sort rules alphabetically to make comparisons with other projects using the template easier.
  • Remove support for node 6, target node 10, and increment minor version.

New rules were added as the result of this update
	*no shadow: temporarily turned off for this change
        *jsdoc/no undefined types: turned off
        *jsdoc/newline-after-description: automatically fixed
using fix script.

Remove max-len override in app.js as not emitting warning
Remove extends rules which are now
included upstream in wikimedia/server,
as well as individual rule also
included (prefer const now errors
by default.)
These were only partially alphabetised. This
makes it easier to compare rules with
other repositories using the template.
We no longer support 6 in production, so
remove support travis builds for it.

Also re-add in node (dev version)  which was
previously removed in 22758bd, as it's
good to test against future versions of node.
@mvolz mvolz changed the title Update linting packages and fix issues accordingly Update linting packages and release version 0.8.0 Nov 17, 2020
@mvolz mvolz requested a review from berndsi November 17, 2020 14:13
@Pchelolo Pchelolo merged commit 7989407 into master Nov 19, 2020
@mvolz mvolz deleted the updatelint branch August 11, 2021 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants