Require node 18 or higher, update to 6.0.0 #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The breaking change part of this PR is OK, but tagging this particular patch as the 6.0.0 release seems premature? |
mvolz
changed the title
Collaborator
Author
|
Better? :) |
Member
No, worse. This is a breaking change, so the next release will definitely be 6.0.0. I just don't think this MR should be considered the release point. |
Collaborator
Author
|
This release point includes this breaking change: f4f793f I would like to release it ASAP as it's blocking us from updating citoid to 18 and 20. |
Due to localhost now pointing to IPv6 instead of IPv4 as of node 18, TestServer now explicitly serves 127.0.0.1 instead of localhost. Consumers who import the TestServer from service runner will need to update their test runner applications to serve from 127.0.0.1 as well in order to upgrade from node16 to node 18, in addition to upgrading from 5.0.0 to 6.0.0.
mvolz
changed the title
edg2s
approved these changes
Nov 1, 2024
Member
|
What else needs to be in this release? I'm happy for this to go as is... |
Member
If we're doing this, we could land !253 too, for instance. But eh, fine, let's just call this the release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to localhost now pointing to IPv6 instead of IPv4 as of node 18, TestServer now explicitly serves 127.0.0.1 instead of localhost.
Consumers who import the TestServer from service runner will need to update their test runner applications to serve from 127.0.0.1 as well in order to upgrade from node16 to node 18, in addition to upgrading from 5.0.0 to 6.0.0.