If we increase the node version to 18(LTS, Maintainance mode) or later, 'fetch' API is standardized and stable in node. No need for an external library.
(cxserver just migrated away from preq using node native fetch https://phabricator.wikimedia.org/T350773)

If we increase the node version to 18(LTS, Maintainance mode) or later, 'fetch' API is standardized and stable in node. No need for an external library. (cxserver just migrated away from preq using node native fetch https://phabricator.wikimedia.org/T350773)

Yes, but other parts of the library aren't yet compatible with Node 18, so we can't do that right now (until I or someone else has the time to fix those incompatibilities).

Not sure what's causing the errors here, but as I'm looking into preq for an unrelated issue, I thought I should note it differs from fetch in at least two ways:

Preq is wrapping errors, so we might loose some logging features upstream if those are not replaced upstream;

Preq uses another defunct library called requestretry to automatically retry requests once after a short time out.

Not sure what's causing the errors here, but as I'm looking into preq for an unrelated issue, I thought I should note it differs from fetch in at least two ways:

Preq is wrapping errors, so we might loose some logging features upstream if those are not replaced upstream;

Preq uses another defunct library called requestretry to automatically retry requests once after a short time out.

Yeah, those two are things to bear in mind for downstream users if they're just preq in prod code, but given this is tests-only here I think it should be fine. But then, it's breaking tests (or something else is), so… :-(

Weird this works in 20 but not 18 now. Should we just have this be 7.0.0. and drop 18? :)

Weird this works in 20 but not 18 now. Should we just have this be 7.0.0. and drop 18? :)

Yeah, I'm not quite sure what's going on there – possibly an upstream library version issue? Anyway, let's do that (but in a different PR); most users have bumped by now.

Edit: Proposed in #263 .