Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: wikimedia/service-runner
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: wikimedia/service-runner
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: enable-gc-metric-collection
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 6 commits
  • 8 files changed
  • 2 contributors

Commits on Dec 12, 2024

  1. promethus: collect default metrics. 

    Add a config option to collect default metrics
(including GC). This should be enable only when
running with no workers.
    @gmodena @jdforrester
    gmodena authored and jdforrester committed Dec 12, 2024
    Configuration menu
    Copy the full SHA
    16f21ce View commit details
    Browse the repository at this point in the history

  2. prometheus: collect_default validation in cluster 

    Throw an excpetion if metrics.prometheus.collect_default
is enabled in cluster mode.
    @gmodena @jdforrester
    gmodena authored and jdforrester committed Dec 12, 2024
    Configuration menu
    Copy the full SHA
    6f1dc03 View commit details
    Browse the repository at this point in the history

  3. prometheus: fix attribute access

    @gmodena @jdforrester
    gmodena authored and jdforrester committed Dec 12, 2024
    Configuration menu
    Copy the full SHA
    b4fabf5 View commit details
    Browse the repository at this point in the history

  4. metric: add noop metrics. 

    Add a noop type of metric not registered by service-runner Metric interface.
This is used to delegate collection of default prometheus
metrics to prom-client.collectDefaultMetrics.
    @gmodena @jdforrester
    gmodena authored and jdforrester committed Dec 12, 2024
    Configuration menu
    Copy the full SHA
    7036c50 View commit details
    Browse the repository at this point in the history

  5. build: Apply eslint fixes to the GC stack

    @jdforrester
    jdforrester committed Dec 12, 2024
    Configuration menu
    Copy the full SHA
    7461e27 View commit details
    Browse the repository at this point in the history

  6. tests: Re-work to use fetch not removed preq, per rebase

    @jdforrester
    jdforrester committed Dec 12, 2024
    Configuration menu
    Copy the full SHA
    2bee736 View commit details
    Browse the repository at this point in the history
Loading