tests: Re-work to use fetch not removed preq, per rebase

jdforrester · jdforrester · commit 2bee7361836c · 2024-12-12T11:17:07.000-05:00
diff --git a/lib/heapwatch.js b/lib/heapwatch.js
@@ -5,8 +5,8 @@ const cluster = require( 'cluster' );
 class HeapWatch {
 	constructor( conf, logger, metrics ) {
 		if ( metrics !== null ) {
-			const prometheusOptions = metrics.options.find( ( option ) =>
-				option.type === 'prometheus' && option.collect_default === true
+			const prometheusOptions = metrics.options.find(
+				( option ) => option.type === 'prometheus' && option.collect_default === true
 			);
 			// When true, a noop dummy metric will be instantiated
 			// and passed down to a PrometheusClient instance.
diff --git a/lib/worker.js b/lib/worker.js
@@ -119,7 +119,6 @@ class Worker extends BaseService {
 		// For 0.10: npm install heapdump
 		process.on( 'SIGUSR2', this._dumpHeapHandler = () => {
 			try {
-				// eslint-disable-next-line n/no-missing-require
 				const heapdump = require( 'heapdump' );
 				const cwd = process.cwd();
 				console.error( 'SIGUSR2 received! Writing snapshot.' );
diff --git a/test/features/tests.js b/test/features/tests.js
@@ -105,11 +105,13 @@ describe( 'service-runner tests', () => {
 		const server = new TestServer( `${ __dirname }/../utils/simple_config_no_workers_collect_default.yaml` );
 		const response = { status: null, body: null };
 		return server.start()
-			.then( () => {
-				preq.get( { uri: 'http://127.0.0.1:9000' } )
-					.then( ( res ) => {
+			.then( async () => {
+				// eslint-disable-next-line n/no-unsupported-features/node-builtins
+				await fetch( 'http://127.0.0.1:9000' )
+					.then( async ( res ) => {
 						response.status = res.status;
-						response.body = res.body;
+						// This is a ReadableStream of a Uint8Array, but we just want the string
+						response.body = new TextDecoder().decode( await res.arrayBuffer() );
 					} );
 			} )
 			.delay( 1000 )
@@ -123,8 +125,6 @@ describe( 'service-runner tests', () => {
 			.finally( () => server.stop() );
 	} );
 
-	// preq prevents the AssertionErrors from surfacing and failing the test
-	// performing the test this way presents them correctly
 	it( 'Must increment hitcount metrics when hit, no workers', () => {
 		const server = new TestServer( `${ __dirname }/../utils/simple_config_no_workers.yaml` );
 		const response = { status: null, body: null };
