Bugfix: clone labels when interpolating metric name (#235)

shdubsh · web-flow · commit 033cfc9e82b2 · 2021-04-01T17:12:19.000-04:00
When the log metrics output is first in line,
`metrics.utils.formatLabels` will mutate the labels array.
This mutation will leak to the other metrics clients and manifest
as an Invalid number of arguments in prom-client.

Bump to 2.8.2

Bug: T278141
diff --git a/lib/metrics/utils/index.js b/lib/metrics/utils/index.js
@@ -28,15 +28,16 @@ function zipLabels(options, labels) {
 
 // Formats label set with metric name
 function formatLabels(options, labels) {
+    let formattedLabels = [...labels];
     if (options.labels.names) {
-        labels = zipLabels(options, labels);
+        formattedLabels = zipLabels(options, formattedLabels);
     }
     if (options.labels.labelPosition === 'before') {
-        labels.push(options.name);
+        formattedLabels.push(options.name);
     } else {
-        labels.unshift(options.name);
+        formattedLabels.unshift(options.name);
     }
-    return labels;
+    return formattedLabels;
 }
 
 module.exports.normalizeName = normalizeName;
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "service-runner",
-  "version": "2.8.1",
+  "version": "2.8.2",
   "description": "Generic nodejs service supervisor / cluster runner",
   "main": "service-runner.js",
   "bin": {

Original file line number	Diff line number	Diff line change
`@@ -28,15 +28,16 @@ function zipLabels(options, labels) {`
`28`	`28`
`29`	`29`	`// Formats label set with metric name`
`30`	`30`	`function formatLabels(options, labels) {`
	`31`	`+ let formattedLabels = [...labels];`
`31`	`32`	`if (options.labels.names) {`
`32`		`- labels = zipLabels(options, labels);`
	`33`	`+ formattedLabels = zipLabels(options, formattedLabels);`
`33`	`34`	`}`
`34`	`35`	`if (options.labels.labelPosition === 'before') {`
`35`		`- labels.push(options.name);`
	`36`	`+ formattedLabels.push(options.name);`
`36`	`37`	`} else {`
`37`		`- labels.unshift(options.name);`
	`38`	`+ formattedLabels.unshift(options.name);`
`38`	`39`	`}`
`39`		`- return labels;`
	`40`	`+ return formattedLabels;`
`40`	`41`	`}`
`41`	`42`
`42`	`43`	`module.exports.normalizeName = normalizeName;`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "service-runner",`
`3`		`- "version": "2.8.1",`
	`3`	`+ "version": "2.8.2",`
`4`	`4`	`"description": "Generic nodejs service supervisor / cluster runner",`
`5`	`5`	`"main": "service-runner.js",`
`6`	`6`	`"bin": {`