Parsoid: Stash: Honour our own ETag when retrieving the stash #1208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a client is switching between wikitext and HTML and in one of the two transforms they fail to provide the revision in the URI, trust that the ETag is correct and try to retrieve the stashed content using the information in the ETag. As a fall-back, though, try with the client-supplied revision as well. Bug: T235465
Pchelolo
approved these changes
Oct 15, 2019
Contributor
|
Something seemingly unrelated is breaking the tests! |
Contributor
Author
Random Cassandra failures. I've encountered these a number of times over the last period. Only the last set of tests is failing with Cassandra not responding. Restarted them. Locally all is good, ofc. |
d00rman
pushed a commit
to d00rman/restbase
that referenced
this pull request
Oct 16, 2019
If a client is switching between wikitext and HTML and in one of the two transforms they fail to provide the revision in the URI, trust that the ETag is correct and try to retrieve the stashed content using the information in the ETag. As a fall-back, though, try with the client-supplied revision as well. This is a port of wikimedia#1208 to the proxy branch. Bug: T235465
d00rman
pushed a commit
to d00rman/restbase
that referenced
this pull request
Oct 16, 2019
If a client is switching between wikitext and HTML and in one of the two transforms they fail to provide the revision in the URI, trust that the ETag is correct and try to retrieve the stashed content using the information in the ETag. As a fall-back, though, try with the client-supplied revision as well. This is a port of wikimedia#1208 to the proxy branch. Bug: T235465
d00rman
pushed a commit
that referenced
this pull request
Oct 28, 2019
If a client is switching between wikitext and HTML and in one of the two transforms they fail to provide the revision in the URI, trust that the ETag is correct and try to retrieve the stashed content using the information in the ETag. As a fall-back, though, try with the client-supplied revision as well. This is a port of #1208 to the proxy branch. Bug: T235465
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a client is switching between wikitext and HTML and in one of the two
transforms they fail to provide the revision in the URI, trust that the
ETag is correct and try to retrieve the stashed content using the
information in the ETag. As a fall-back, though, try with the
client-supplied revision as well.
Bug: T235465