Skip to content

Parsoid: Add the variant proxy #1207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
d00rman merged 11 commits into from
Oct 28, 2019
Merged

Parsoid: Add the variant proxy #1207

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a8fb336
Parsoid: Move the Parsoid class to lib/parsoid.js
Oct 12, 2019
56cbde4
Parsoid: Create the modules for both variants
Oct 12, 2019
eec926e
Parsoid: Add the variant proxy
Oct 13, 2019
3a7cfeb
Parsoid: Use Parsoid/PHP for tests using Beta wikipedia
Oct 13, 2019
cce372e
Parsoid: Add fallback for transforms to the proxy
Oct 15, 2019
a5d5f5d
Parsoid: Throw errors for unimplemented methods
Oct 15, 2019
8cfead2
Parsoid: Stash: Honour our own ETag when retrieving the stash
Oct 16, 2019
3d63e77
Minor: Parsoid: No return JSDoc for abstract methods
Oct 22, 2019
1665ed0
Parsoid: Tests: Add Parsoid/PHP to the list of allowed URLs
Oct 24, 2019
ccdf409
Parsoid: Set content-language and vary if they are missing
Oct 24, 2019
cd991c8
Travis: Start Cassandra only for the `cassandra` test target
Oct 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Parsoid: Throw errors for unimplemented methods 
Bug: T230791
  • Loading branch information
Marko Obrovac committed Oct 16, 2019
commit a5d5f5d2613f9c2f264fcdaf2f57413dd9e313d5
38 changes: 38 additions & 0 deletions lib/parsoid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,44 @@ class ParsoidService {
}
}

/**
* Assembles the request that is to be used to call the Parsoid service
*
* @param {Object} req the original request received by the module
* @param {string} path the path portion of the URI, without the domain or API version
* @param {Object} [headers] the headers to send, defaults to req.headers
* @param {Object} [body] the body of the request, defaults to undefined
* @return {Object} the request object to send
*/
_getParsoidReq(req, path, headers, body) {
throw new Error('Parsoid module: _getParsoidReq() not implemented!');
}

/**
* Gets the URI of a bucket for the latest Parsoid content
*
* @param {string} domain the domain name
* @param {string} title the article title
* @return {HyperSwitch.URI}
*/
_getLatestBucketURI(domain, title) {
throw new Error('Parsoid module: _getLatestBucketURI() not implemented!');
}

/**
* Gets the URI of a bucket for stashing Parsoid content. Used both for stashing
* original HTML/Data-Parsoid for normal edits as well as for stashing transforms
*
* @param {string} domain the domain name
* @param {string} title the article title
* @param {number} revision the revision of the article
* @param {string} tid the TID of the content
* @return {HyperSwitch.URI}
*/
_getStashBucketURI(domain, title, revision, tid) {
throw new Error('Parsoid module: _getStashBucketURI() not implemented!');
}

/**
* Get full content from the stash bucket.
* @param {HyperSwitch} hyper the hyper object to route requests
Expand Down