build: Enable phan plugin UseReturnValuePlugin

umherirrender · umherirrender · commit 9280b584f23c · 2021-08-26T21:08:19.000Z
Suppress false positives

Bug: T240141
Change-Id: Ie356512ad76de465b1fda5b913fa30702339cb11
diff --git a/includes/libs/uuid/GlobalIdGenerator.php b/includes/libs/uuid/GlobalIdGenerator.php
@@ -724,6 +724,7 @@ public function unitTestTearDown() {
 	}
 
 	public function __destruct() {
+		// @phan-suppress-next-line PhanPluginUseReturnValueInternalKnown
 		array_map( 'fclose', array_filter( $this->fileHandles ) );
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -724,6 +724,7 @@ public function unitTestTearDown() {`
`724`	`724`	`}`
`725`	`725`
`726`	`726`	`public function __destruct() {`
	`727`	`+ // @phan-suppress-next-line PhanPluginUseReturnValueInternalKnown`
`727`	`728`	`array_map( 'fclose', array_filter( $this->fileHandles ) );`
`728`	`729`	`}`
`729`	`730`	`}`