uuid: Switch mt_rand() calls to random_int() in GlobalIdGenerator

AaronSchulz · Krinkle · commit 817eabbde453 · 2024-10-01T18:20:55.000Z
This makes initial clock sequence numbers the strength of the node IDs.
Both of which are stored in /tmp files.

Change-Id: Ia831baa19a7ba882c3d18196decb7bf3347a4c43
diff --git a/includes/libs/uuid/GlobalIdGenerator.php b/includes/libs/uuid/GlobalIdGenerator.php
@@ -525,7 +525,7 @@ protected function getTimeAndDelay( $lockFile, $clockSeqSize, $counterSize, $off
 				$clkSeq = ( $clkSeq + 1 ) % $clockSeqSize;
 				$sec = time();
 				$msecCounter = 0;
-				$randOffset = mt_rand( 0, $offsetSize - 1 );
+				$randOffset = random_int( 0, $offsetSize - 1 );
 				trigger_error( "Clock was set back; sequence number incremented." );
 			} elseif ( $sec === $prevSec ) {
 				// The time matches the last ID. Bump the tie-breaking counter.
@@ -541,10 +541,10 @@ protected function getTimeAndDelay( $lockFile, $clockSeqSize, $counterSize, $off
 			}
 		} else {
 			// Initialize UID lock file information
-			$clkSeq = mt_rand( 0, $clockSeqSize - 1 );
+			$clkSeq = random_int( 0, $clockSeqSize - 1 );
 			$sec = time();
 			$msecCounter = 0;
-			$randOffset = mt_rand( 0, $offsetSize - 1 );
+			$randOffset = random_int( 0, $offsetSize - 1 );
 		}
 
 		// Update and release the UID lock file
