phan: Disable null_casts_as_any_type setting

umherirrender · Krinkle · commit 4fc2b6629826 · 2022-03-21T18:25:07.000Z
Make phan stricter about null types by setting null_casts_as_any_type to
false (the default in mediawiki-phan-config)
Remaining false positive issues are suppressed.
The suppression and the setting change can only be done together

Bug: T242536
Bug: T301991
Change-Id: I0f295382b96fb3be8037a01c10487d9d591e7e01
diff --git a/includes/libs/uuid/GlobalIdGenerator.php b/includes/libs/uuid/GlobalIdGenerator.php
@@ -632,6 +632,7 @@ protected function intervalsSinceGregorianBinary( array $time, $delta = 0 ) {
 			$ts = bcadd( $ts, (string)$delta );
 			// wrap around
 			$ts = bcmod( $ts, bcpow( '2', '60' ) );
+			// @phan-suppress-next-line PhanTypeMismatchArgumentNullable Only null if second arg is 0
 			$id_bin = \Wikimedia\base_convert( $ts, 10, 2, 60 );
 		} else {
 			throw new RuntimeException( 'bcmath or gmp extension required for 32 bit machines.' );
@@ -661,6 +662,7 @@ private function load() {
 				$csv = trim( ( $this->shellCallback )( 'getmac /NH /FO CSV' ) );
 				$line = substr( $csv, 0, strcspn( $csv, "\n" ) );
 				$info = str_getcsv( $line );
+				// @phan-suppress-next-line PhanTypeMismatchArgumentNullableInternal False positive
 				$nodeId = isset( $info[0] ) ? str_replace( '-', '', $info[0] ) : '';
 			} elseif ( is_executable( '/sbin/ifconfig' ) ) {
 				// Linux/BSD/Solaris/OS X
