uuid: avoid PHP warnings in GlobalIdGenerator::load()

AaronSchulz · AaronSchulz · commit 4b2278145554 · 2023-05-11T12:47:46.000-07:00
Make sure that preg_match() is not passed false instead of a string

Change-Id: I9571010f23afcfce4b42e14d29707879b3c556d1
diff --git a/includes/libs/uuid/GlobalIdGenerator.php b/includes/libs/uuid/GlobalIdGenerator.php
@@ -657,10 +657,8 @@ private function load() {
 
 		$this->loaded = true;
 
-		$nodeId = '';
-		if ( is_file( $this->nodeIdFile ) ) {
-			$nodeId = file_get_contents( $this->nodeIdFile );
-		}
+		// phpcs:ignore Generic.PHP.NoSilencedErrors.Discouraged
+		$nodeId = @file_get_contents( $this->nodeIdFile ) ?: '';
 		// Try to get some ID that uniquely identifies this machine (RFC 4122)...
 		if ( !preg_match( '/^[0-9a-f]{12}$/i', $nodeId ) ) {
 			AtEase::suppressWarnings();
