Skip to content

Commit 03b65df

Browse files
jdforresterumherirrender
authored andcommitted
phan: Upgrade mediawiki-phan-config to 0.11.1 and set minimum_target_php_version
MediaWiki still supports PHP 7.2+, but we want to mainly test in newer versions of PHP. Setting minimum_target_php_version to 7.2 this lets us run phan without phan trying to get us to make PHP 7.2-incompatible changes to 'appease' PHP 8.0 or whatever later changes. Some switches of generic 'resource' type-hinting to 'resource|object' to inform phan to ignore this (triggering PHPCS at the time, ah well), rather than trying to hint the specific novel PHP encapsulation classes to that have replaced them from PHP 8.0 onwards but don't yet exist, and fixes from where we were checking the results of implode and explode. Bug: T293924 Change-Id: I629e3fb3adfad73beb3d424a07e643c2e079d9bb
1 parent 4fc2b66 commit 03b65df

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

includes/libs/uuid/GlobalIdGenerator.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -632,7 +632,6 @@ protected function intervalsSinceGregorianBinary( array $time, $delta = 0 ) {
632632
$ts = bcadd( $ts, (string)$delta );
633633
// wrap around
634634
$ts = bcmod( $ts, bcpow( '2', '60' ) );
635-
// @phan-suppress-next-line PhanTypeMismatchArgumentNullable Only null if second arg is 0
636635
$id_bin = \Wikimedia\base_convert( $ts, 10, 2, 60 );
637636
} else {
638637
throw new RuntimeException( 'bcmath or gmp extension required for 32 bit machines.' );

0 commit comments

Comments
 (0)