Skip to content

php.yml: Test on PHP 8.3-8.5 #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jdforrester merged 3 commits into from
Nov 25, 2025
Merged

php.yml: Test on PHP 8.3-8.5 #461

jdforrester merged 3 commits into from
Nov 25, 2025

Conversation

@reedy
Copy link
Member

@reedy reedy commented Nov 25, 2025

No description provided.

@jdforrester
Copy link
Member

jdforrester commented Nov 25, 2025

Does it not pass on 8.5? If it passes, it'd be good to add the check now.

@reedy
Copy link
Member Author

reedy commented Nov 25, 2025

Does it not pass on 8.5? If it passes, it'd be good to add the check now.

I didn't check, but was more interested for WMF usage (8.3 and integration into MW core #372), and similarly PHP 8.4 being stable enough at this point...

@reedy reedy changed the title php.yml: Test on PHP 8.3 and 8.4 php.yml: Test on PHP 8.3-8.5 Nov 25, 2025
@jdforrester jdforrester merged commit d81de3d into wikimedia:master Nov 25, 2025
9 checks passed
@reedy reedy deleted the reedy-patch-2 branch November 25, 2025 17:02
@Abijeet
Copy link
Member

Abijeet commented Dec 1, 2025

Had to disable PHP 8.5 CI

 /home/runner/work/language-data/language-data/vendor/phan/phan/src/Phan/CodeBase.php:590 [8192] Method SplObjectStorage::attach() is deprecated since 8.5, use method SplObjectStorage::offsetSet() instead
(Phan 5.5.1 crashed)
More details:
#2: Phan\CodeBase->addInternalFunctionsByNames() called at [/home/runner/work/language-data/language-data/vendor/phan/phan/src/Phan/CodeBase.php:243] Args: [["clone", "exit", "die", "zend_version", "func_num_args", "func_get_arg", "func_get_args", "strlen", "strcmp", "strncmp", ... 2328 more element(s)]]
#3: Phan\CodeBase->__construct() called at [/home/runner/work/language-data/language-data/vendor/phan/phan/src/codebase.php:16] Args: [["InternalIterator", "Exception", "ErrorException", "Error", "CompileError", "ParseError", "TypeError", "ArgumentCountError", "ValueError", "ArithmeticError", ... 429 more element(s)], ["Traversable", "IteratorAggregate", "Iterator", "Serializable", "ArrayAccess", "Countable", "Stringable", "Throwable", "UnitEnum", "BackedEnum", ... 64 more element(s)], ["Phan\\PluginV3\\IssueEmitter"], ["true", "false", "null", "E_ERROR", "E_WARNING", "E_PARSE", "E_NOTICE", "E_CORE_ERROR", "E_CORE_WARNING", "E_COMPILE_ERROR", ... 3569 more element(s)], ["clone", "exit", "die", "zend_version", "func_num_args", "func_get_arg", "func_get_args", "strlen", "strcmp", "strncmp", ... 2328 more element(s)]]

See: https://github.com/wikimedia/language-data/actions/runs/19819690893/job/56779101738?pr=465

@reedy
Copy link
Member Author

reedy commented Dec 1, 2025

I think that's known... waiting for some upstream work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nikerabbit Nikerabbit Nikerabbit approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@reedy @jdforrester @Abijeet @Nikerabbit